-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14022#Move local storage info up a level for visibility #97182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Wed Aug 20 18:50:17 - Prow CI generated the docs preview: |
|
Thanks for working on it! |
|
This link is in the first comment now. |
|
The preview renders with the old style (that we all love) but it's in the top level of the storage section now so i assume it will be reflected the same way on docs.redhat.com? |
748b5fa to
2a4a95f
Compare
storage/persistent_storage_local/persistent-storage-using-lvms.adoc
Outdated
Show resolved
Hide resolved
storage/persistent_storage_local/persistent-storage-using-lvms.adoc
Outdated
Show resolved
Hide resolved
2053f21 to
a789457
Compare
|
LGTM |
|
@gcharot It doesn't look like Daniel Fleischman is with the company anymore. Anyone else that should review/approve? |
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
DanielFroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cherrypick enterprise-4.20 |
|
@lpettyjo: new pull request created: #98117 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.19 |
|
@lpettyjo: new pull request created: #98118 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.18 |
|
@lpettyjo: #97182 failed to apply on top of branch "enterprise-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OSDOCS-14022
Link to docs preview: https://97182--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage_local/ways-to-provision-local-storage
QE review:
Additional information:
PTAL: @gcharot @danielf