Skip to content

TELCODOCS-2430 - Correcting PTP event notification examples #97318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

TELCODOCS-2430 - Correcting PTP event notification examples #97318

merged 1 commit into from
Sep 2, 2025

Conversation

@slovern
Copy link
Contributor

@slovern slovern commented Aug 7, 2025 •
edited by amolnar-gh
Loading

TELCODOCS-2430 - Correcting PTP event notification examples

Version(s):

  • 4.20
  • 4.19
  • 4.18
  • 4.17
  • 4.16

Issue: https://issues.redhat.com/browse/TELCODOCS-2430

Link to docs preview: api/ocloudNotifications/v2/{resource_address}/CurrentState

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 7, 2025 •
edited
Loading

🤖 Wed Aug 27 11:22:52 - Prow CI generated the docs preview:

https://97318--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/ptp/ptp-events-rest-api-reference-v2.html

jzding
jzding reviewed Aug 21, 2025
View reviewed changes
modules/cnf-fast-event-notifications-api-reference-v2.adoc Outdated
"version": "1.0",
"values": [
{
"resource": "/cluster/node/compute-1.example.com/ens2fx/master",
Copy link

@jzding jzding Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource should change to ResourceAddress

jzding
jzding reviewed Aug 21, 2025
View reviewed changes
modules/cnf-fast-event-notifications-api-reference-v2.adoc Outdated
"value": "SYNCHRONIZED"
},
{
"resource": "/cluster/node/compute-1.example.com/ens2fx/master",
Copy link

@jzding jzding Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource should change to ResourceAddress

Copy link
Contributor Author

@slovern slovern Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jzding I've corrected both instances

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2025

@slovern: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jzding
jzding approved these changes Aug 27, 2025
View reviewed changes
Copy link

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025
@Bonnie-Block
Copy link

Bonnie-Block commented Aug 28, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2025

@Bonnie-Block: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amolnar-gh amolnar-gh added this to the Continuous Release milestone Sep 2, 2025
@amolnar-gh amolnar-gh merged commit 419fa45 into openshift:main Sep 2, 2025
2 checks passed
@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 2, 2025

/cherrypick enterprise-4.16

@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 2, 2025

/cherrypick enterprise-4.17

@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 2, 2025

/cherrypick enterprise-4.18

@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 2, 2025

/cherrypick enterprise-4.19

@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 2, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 2, 2025

@amolnar-rh: new pull request created: #98344

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 2, 2025

@amolnar-rh: #97318 failed to apply on top of branch "enterprise-4.17":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 2, 2025

@amolnar-rh: new pull request created: #98345

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Sep 2, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 2, 2025

@amolnar-rh: new pull request created: #98346

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 2, 2025

@amolnar-rh: new pull request created: #98347

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 2, 2025
Merged
@amolnar-gh
Copy link
Contributor

amolnar-gh commented Sep 2, 2025

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 2, 2025

@amolnar-rh: new pull request created: #98350

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jzding jzding jzding approved these changes

@amolnar-gh amolnar-gh amolnar-gh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jzding jzding

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@slovern @ocpdocs-previewbot @Bonnie-Block @amolnar-gh @openshift-cherrypick-robot @jzding