OSDOCS-15203:CQA for associating secondary metrics #97356

JoeAldinger · 2025-08-08T16:29:51Z

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-15224

Link to docs preview:

QE review:

QE has approved this change.
SME has approved this change.

Additional information:

openshift-ci-robot · 2025-08-08T16:29:55Z

@JoeAldinger: This pull request references OSDOCS-15203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-08T16:34:33Z

@JoeAldinger: This pull request references OSDOCS-15203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-15224

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-08-08T16:39:23Z

🤖 Mon Aug 11 17:37:08 - Prow CI generated the docs preview:

https://97356--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/advanced_networking/associating-secondary-interfaces-metrics-to-network-attachments.html

modules/cnf-metrics-secondary-interfaces-by-name.adoc

modules/cnf-network-metrics-daemon.adoc

openshift-ci · 2025-08-11T17:38:37Z

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

asood-rh · 2025-08-13T19:18:23Z

/lgtm

As per Joe, it is reorganization PR.

openshift-ci-robot · 2025-08-13T19:19:22Z

@JoeAldinger: This pull request references OSDOCS-15203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-15224

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

palonsoro · 2025-09-15T08:37:20Z

/lgtm

openshift-ci-robot · 2025-09-15T13:44:41Z

@JoeAldinger: This pull request references OSDOCS-15203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-15224

Link to docs preview:

QE review:

QE has approved this change.

SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jab-rh

@JoeAldinger, left a few minor comments, but doesn't prevent getting it merged.

jab-rh · 2025-09-15T17:06:43Z

modules/cnf-network-metrics-daemon.adoc

+* Pod namespace
+* Interface name (such as `eth0`)
+
+These metrics work well until new interfaces are added to the pod, for example via https://github.com/intel/multus-cni[Multus], as it is not clear what the interface names refer to.


@JoeAldinger, historically we've needed permission for linking to GitHub as I recall.

jab-rh · 2025-09-15T17:07:15Z

modules/cnf-network-metrics-daemon.adoc

+
+:_mod-docs-content-type: CONCEPT
+[id="cnf-network-metrics-daemon_{context}"]
+= Network Metrics Daemon


Do we actually capitalize Daemon for this?

I think in this case it does get capitalize 🤷🏻 https://github.com/openshift/network-metrics-daemon.

JoeAldinger · 2025-09-15T18:48:48Z

/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16
/cherrypick enterprise-4.15
/cherrypick enterprise-4.14
/cherrypick enterprise-4.13
/cherrypick enterprise-4.12

openshift-cherrypick-robot · 2025-09-15T18:49:36Z

@JoeAldinger: #97356 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-15203:CQA for associating secondary metrics
Using index info to reconstruct a base tree...
M	modules/cnf-associating-secondary-interfaces-metrics-to-network-attachments.adoc
A	networking/advanced_networking/associating-secondary-interfaces-metrics-to-network-attachments.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/cnf-associating-secondary-interfaces-metrics-to-network-attachments.adoc
CONFLICT (content): Merge conflict in modules/cnf-associating-secondary-interfaces-metrics-to-network-attachments.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-15203:CQA for associating secondary metrics

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16
/cherrypick enterprise-4.15
/cherrypick enterprise-4.14
/cherrypick enterprise-4.13
/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoeAldinger · 2025-09-15T19:04:00Z

/cherrypick enterprise-4.20

JoeAldinger · 2025-09-15T19:04:13Z

/cherrypick enterprise-4.19

JoeAldinger · 2025-09-15T19:04:28Z

/cherrypick enterprise-4.18

JoeAldinger · 2025-09-15T19:04:39Z

/cherrypick enterprise-4.17

JoeAldinger · 2025-09-15T19:04:49Z

/cherrypick enterprise-4.16

openshift-cherrypick-robot · 2025-09-15T19:04:54Z

@JoeAldinger: new pull request created: #99073

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-09-15T19:05:01Z

@JoeAldinger: new pull request created: #99074

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoeAldinger · 2025-09-15T19:05:02Z

/cherrypick enterprise-4.15

JoeAldinger · 2025-09-15T19:05:15Z

/cherrypick enterprise-4.14

openshift-cherrypick-robot · 2025-09-15T19:05:18Z

@JoeAldinger: new pull request created: #99075

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoeAldinger · 2025-09-15T19:05:25Z

/cherrypick enterprise-4.13

openshift-cherrypick-robot · 2025-09-15T19:05:28Z

@JoeAldinger: new pull request created: #99076

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoeAldinger · 2025-09-15T19:05:37Z

/cherrypick enterprise-4.12

openshift-cherrypick-robot · 2025-09-15T19:05:39Z

@JoeAldinger: new pull request created: #99077

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-09-15T19:05:53Z

@JoeAldinger: new pull request created: #99078

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-09-15T19:06:08Z

@JoeAldinger: new pull request created: #99079

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-09-15T19:06:17Z

@JoeAldinger: new pull request created: #99080

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-09-15T19:06:23Z

@JoeAldinger: #97356 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-15203:CQA for associating secondary metrics
Using index info to reconstruct a base tree...
M	modules/cnf-associating-secondary-interfaces-metrics-to-network-attachments.adoc
A	networking/advanced_networking/associating-secondary-interfaces-metrics-to-network-attachments.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/cnf-associating-secondary-interfaces-metrics-to-network-attachments.adoc
CONFLICT (content): Merge conflict in modules/cnf-associating-secondary-interfaces-metrics-to-network-attachments.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-15203:CQA for associating secondary metrics

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2025

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2025

JoeAldinger added branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 labels Aug 8, 2025

JoeAldinger added this to the Continuous Release milestone Aug 8, 2025

ocpdocs-vale-bot reviewed Aug 8, 2025

View reviewed changes

modules/cnf-metrics-secondary-interfaces-by-name.adoc Outdated Show resolved Hide resolved

ocpdocs-vale-bot reviewed Aug 8, 2025

View reviewed changes

modules/cnf-network-metrics-daemon.adoc Outdated Show resolved Hide resolved

JoeAldinger force-pushed the OSDOCS-15203 branch from 7ac1ef0 to ab3bd81 Compare August 8, 2025 16:45

OSDOCS-15203:CQA for associating secondary metrics

a0553e7

JoeAldinger force-pushed the OSDOCS-15203 branch from ab3bd81 to a0553e7 Compare August 11, 2025 17:23

openshift-ci bot assigned asood-rh Aug 13, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025

openshift-ci bot assigned palonsoro Sep 15, 2025

JoeAldinger added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 15, 2025

jab-rh reviewed Sep 15, 2025

View reviewed changes

JoeAldinger merged commit f5e1553 into openshift:main Sep 15, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.20] OSDOCS-15203:CQA for associating secondary metrics #99073

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.19] OSDOCS-15203:CQA for associating secondary metrics #99074

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.18] OSDOCS-15203:CQA for associating secondary metrics #99075

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.17] OSDOCS-15203:CQA for associating secondary metrics #99076

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.16] OSDOCS-15203:CQA for associating secondary metrics #99077

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.15] OSDOCS-15203:CQA for associating secondary metrics #99078

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.14] OSDOCS-15203:CQA for associating secondary metrics #99079

Merged

openshift-cherrypick-robot mentioned this pull request Sep 15, 2025

[enterprise-4.13] OSDOCS-15203:CQA for associating secondary metrics #99080

Merged

JoeAldinger mentioned this pull request Sep 15, 2025

[enterprise-4.12] OSDOCS-15203:CQA for associating secondary metrics #99083

Merged

1 task

OSDOCS-15203:CQA for associating secondary metrics #97356

OSDOCS-15203:CQA for associating secondary metrics #97356

Conversation

JoeAldinger commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Aug 11, 2025

Uh oh!

asood-rh commented Aug 13, 2025

Uh oh!

openshift-ci-robot commented Aug 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

palonsoro commented Sep 15, 2025

Uh oh!

openshift-ci-robot commented Sep 15, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jab-rh left a comment

Choose a reason for hiding this comment

Uh oh!

jab-rh Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

jab-rh Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

JoeAldinger Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

JoeAldinger commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 15, 2025

Uh oh!

JoeAldinger commented Aug 8, 2025 •

edited

Loading

openshift-ci-robot commented Aug 8, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 8, 2025 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Aug 8, 2025 •

edited

Loading

openshift-ci-robot commented Aug 13, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 15, 2025 •

edited by openshift-ci bot

Loading