Skip to content

OSDOCS-14500: Prune "Tutorials" #98004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

OSDOCS-14500: Prune "Tutorials" #98004

merged 1 commit into from
Sep 3, 2025

Conversation

@jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Aug 25, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2025 •
edited by openshift-ci bot
Loading

@jneczypor: This pull request references OSDOCS-14500 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

OSDOCS-14500: Prune "Tutorials"

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14500

Link to docs preview:

QE review:
No QE needed

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2025 •
edited by openshift-ci bot
Loading

@jneczypor: This pull request references OSDOCS-14500 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

OSDOCS-14500: Prune "Tutorials"

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14500

Link to docs preview:

QE review:
No QE needed

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 25, 2025 •
edited
Loading

🤖 Wed Sep 03 00:17:15 - Prow CI generated the docs preview:
https://98004--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2025 •
edited by openshift-ci bot
Loading

@jneczypor: This pull request references OSDOCS-14500 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

OSDOCS-14500: Prune "Tutorials"

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-14500

Link to docs preview:
ROSA HCP: https://98004--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cloud_experts_tutorials/
ROSA Classic: https://98004--ocpdocs-pr.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/

QE review:
No QE needed

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jneczypor
Copy link
Contributor Author

jneczypor commented Aug 27, 2025

/test validate-portal

mletalie
mletalie reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly outside the scope of this PR, but I noticed the link issue as shown in the image.
image

Title points to Classic/HCP but directed to OCP docs.

mletalie
mletalie reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I directly commented on a couple of the "docs.openshift" links, but realized there were a few more. Just know that applies to those as well. Thanks!

@mletalie
Copy link
Contributor

mletalie commented Aug 27, 2025

A few comments, otherwise /lgtm. Good job!

@jneczypor jneczypor force-pushed the OSDOCS-14500 branch 2 times, most recently from 876087b to fe89833 Compare August 28, 2025 20:22
@EricPonvelle
Copy link
Contributor

EricPonvelle commented Aug 28, 2025

In addition to the other comments, this operator instance needs to be capitalized (Operator):

image

EricPonvelle
EricPonvelle reviewed Aug 28, 2025
View reviewed changes
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change all core content instances of ROSA to {product-title}

@EricPonvelle
Copy link
Contributor

EricPonvelle commented Aug 28, 2025

Probably intentional, but these books weren't in HCP

image

@EricPonvelle
Copy link
Contributor

EricPonvelle commented Aug 28, 2025

Also delete this from the Classic topic map https://98004--ocpdocs-pr.netlify.app/openshift-rosa/latest/cloud_experts_tutorials/cloud-experts-getting-started/cloud-experts-getting-started-deploying/cloud-experts-getting-started-hcp

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 2, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 2, 2025
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Sep 3, 2025

@jneczypor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mletalie mletalie merged commit ec9a3bd into openshift:main Sep 3, 2025
2 checks passed
@mletalie
Copy link
Contributor

mletalie commented Sep 3, 2025

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 3, 2025

@mletalie: new pull request created: #98435

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 3, 2025
Merged
@mletalie
Copy link
Contributor

mletalie commented Sep 3, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 3, 2025

@mletalie: new pull request created: #98438

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 3, 2025
Merged
@jneczypor jneczypor deleted the OSDOCS-14500 branch September 3, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricPonvelle EricPonvelle EricPonvelle left review comments

@mletalie mletalie mletalie left review comments

+1 more reviewer

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jneczypor @openshift-ci-robot @ocpdocs-previewbot @mletalie @EricPonvelle @openshift-cherrypick-robot @ocpdocs-vale-bot