-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-15983]: Fixing non-technical issues in HCP on OpenShift Virtualization content #98056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDOCS-15983]: Fixing non-technical issues in HCP on OpenShift Virtualization content #98056
Conversation
e6306eb to
0879414
Compare
0879414 to
c501108
Compare
c501108 to
bef66f6
Compare
…alization content
bef66f6 to
09a4fad
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label merge-review-in-progress |
michaelryanpeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise4.18 |
|
@michaelryanpeter: new pull request created: #98062 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.18 |
|
@michaelryanpeter: new pull request created: #98063 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.17 |
|
@michaelryanpeter: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@michaelryanpeter: #98056 failed to apply on top of branch "enterprise-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@michaelryanpeter: #98056 failed to apply on top of branch "enterprise-4.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson It looks like we'll need manual CPs for 4.17 and 4.18. Feel free to ping me with those manual CP PRs when you are ready for a merge. |
|
@michaelryanpeter Thanks! I'll start on those manual CPs. |
Version(s): 4.17+
Issue: https://issues.redhat.com/browse/OSDOCS-15983
Link to docs preview: https://98056--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-virt.html
QE review:
Not required - this PR does not contain technical changes.
Additional information: Related to the CQA for "Deploying hosted control planes on OpenShift Virtualization"