Skip to content

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Aug 28, 2025

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-46504

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
One minor change for the Jira, but I also ran Vale against the file and made updates based on the corrections suggested.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2025

@abrennan89: This pull request references CNV-46504 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-46504

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
One minor change for the Jira, but I also ran Vale against the file and made updates based on the corrections suggested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2025
Copy link

openshift-ci bot commented Aug 28, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 29, 2025

@abrennan89: This pull request references CNV-46504 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-46504

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
One minor change for the Jira, but I also ran Vale against the file and made updates based on the corrections suggested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks right to me.

The source issue mentioned also localnet, which is not treated in this change.
However, I do not think it needs to be specified if there is a default.

It will be good if @phoracek will have a look as well.

@phoracek
Copy link
Member

phoracek commented Sep 4, 2025

This change looks good to me. I see that localnet was already updated to set explicitly 1500 MTU in the example: https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/virtualization/networking#virt-creating-localnet-nad-cli_virt-connecting-vm-to-ovn-secondary-network

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 4, 2025

@abrennan89: This pull request references CNV-46504 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/CNV-46504

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
One minor change for the Jira, but I also ran Vale against the file and made updates based on the corrections suggested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abrennan89 abrennan89 added merge-review-needed Signifies that the merge review team needs to review this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 4, 2025
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.15 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.16 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.17 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.18 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.19 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.20 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abrennan89 abrennan89 merged commit e3be566 into openshift:main Sep 4, 2025
2 checks passed
@openshift-cherrypick-robot

@abrennan89: new pull request created: #98538

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #98539

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #98540

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: once the present PR merges, I will cherry-pick it on top of enterprise-4.14 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #98541

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #98542

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: #98221 failed to apply on top of branch "enterprise-4.14":

Applying: CNV-46504: Updated MTU value and minor vale updates
Using index info to reconstruct a base tree...
M	modules/virt-creating-layer2-nad-cli.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-creating-layer2-nad-cli.adoc
CONFLICT (content): Merge conflict in modules/virt-creating-layer2-nad-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-46504: Updated MTU value and minor vale updates

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #98543

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants