-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Osdocs 16058]Update ROSA CLI attribute #98375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac777b8 to
51db073
Compare
|
🤖 Tue Sep 02 21:30:33 - Prow CI generated the docs preview: |
3cc85c3 to
da46d33
Compare
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| :egress-zero-title: {product-title} clusters with {egress-zero} | ||
| :classic-short: {rosa-classic-short} | ||
| :rosa-cli-first: pass:quotes[Red Hat OpenShift Service on AWS CLI (`rosa`)] | ||
| :rosa-cli-first: pass:quotes[ROSA command-line interface (CLI) (`rosa`)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :rosa-cli-first: pass:quotes[ROSA command-line interface (CLI) (`rosa`)] | |
| :rosa-cli-first: pass:quotes[ROSA command-line interface (CLI) (`rosa`)] | |
| :rosa-cli: ROSA CLI |
We could add this one in and simplify future uses too. Just an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolio, I will add it. Thanks!
|
New changes are detected. LGTM label has been removed. |
aeedfed to
4128812
Compare
|
@mletalie: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.19 |
|
@mletalie: new pull request created: #98398 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.20 |
|
@mletalie: new pull request created: #98399 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19+
Issue:
https://issues.redhat.com/browse/OSDOCS-16058
Link to docs preview:
https://98375--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa-configuring-pid-limits#setting-higher-pid-limit-on-existing-cluster_rosa-configuring-pid-limits
QE review:
Additional information: