OSDOCS16065 Document InPlacePod Resize feature for OpenShift 4.20 #98484
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Mon Oct 06 15:01:24 - Prow CI generated the docs preview: |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
size/XXL
openshift-merge-robot
removed
the
needs-rebase
mburke5678
added
size/L
|
@haircommander PTAL |
| [id="nodes-pods-adjust-resources-in-place-about_{context}"] | ||
| = About in-place pod resizing | ||
|
|
||
| In-place pod resizing allows you to change the CPU and memory resources for containers and sidecar containers within a running pod without application disruption. The standard methods for changing pod CPU and memory resources cause the pod to be re-created, potentially causing disruption. In-place pod resizing allows you to scale pod resources up or down without suffering the downtime or state loss associated with a pod restart. |
There was a problem hiding this comment.
curious why you callout sidecar conatainers, wouldn't containers cover that?
There was a problem hiding this comment.
@haircommander The Kubernetes docs called it out (4th bullet). Thought it might be important. I can remove it if it doesn't make sense here or is redundant.
|
one note but generally looks good |
mburke5678
changed the title
|
@asahay19 Can you also review this PR |
|
/lgtm |
mburke5678
force-pushed
the
node-in-place-update
branch
from
c6ab9e6 to
5efe643
Compare
mburke5678
added
the
merge-review-needed
|
New changes are detected. LGTM label has been removed. |
JoeAldinger
added
merge-review-in-progress
| $ apply -f <file_name>.yaml --subresource resize | ||
| ---- | ||
|
|
||
| [source,terminal] |
There was a problem hiding this comment.
I'm not sure if we need outputs for these. I mention this because I feel like I heard this was part of the 2.0 CQA work or JTBD. I could've hallucinated this too. I couldn't find anything firm on it so this isn't a blocker, IMO.
There was a problem hiding this comment.
At this point, I wanted to show that the --subresource resize flag is required. We aren't concerned with the output at this point.
|
|
||
| Because you need to use the `--subresource resize` flag with a resize policy, you cannot edit the pod resources in the {product-title} web console. | ||
|
|
||
| If the resize policy is `NotRequired` and you change the request or limits, the pod is not restarted. |
There was a problem hiding this comment.
Need a noun following NotRequired. Again, not a deal breaker for merge.
There was a problem hiding this comment.
I don't think so. NotRequired is a value, not an object. Rather like: "Set the parameter to 0"
| resize-pod 1/1 Running 0 5s | ||
| ---- | ||
|
|
||
| If the resize policy is `RestartContainer` and you change the request or limits, the pod is restarted. |
|
|
||
| You can change the CPU or memory resource requests and limits assigned to a container without re-creating or restarting the pod by using _in-place pod resizing_. | ||
|
|
||
| include::modules/nodes-pods-adjust-resources-in-place-about.adoc[leveloffset=+1] |
There was a problem hiding this comment.
need a space between includes
JoeAldinger
removed
the
merge-review-in-progress
mburke5678
force-pushed
the
node-in-place-update
branch
from
5efe643 to
734307e
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@mburke5678: new pull request created: #100059 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9 participants
https://issues.redhat.com/browse/OSDOCS-15958
Link to docs preview:
Adjust pod resource levels without pod disruption -- New assembly
QE review: