-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-15346]: Updating procedure to delete a hosted cluster by using the CLI #98745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Mon Sep 15 17:22:13 - Prow CI generated the docs preview: |
c913ddb to
ef735b7
Compare
ef735b7 to
ca723a7
Compare
jparrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is right, but I'm missing the other part we talk about only use the CLI without render, the cluster is created and also the proper secrets like etcd-encryption, ssh, etc... From Ramon's feedback he metioned the secrets were not being deleted using the CLI in this case. It's worth to mention this?
@jparrill Good question. I can add a note stating that if you did not use the --render and --render-sensitive flags when you created the hosted cluster, you need to manually delete the resources. |
ca723a7 to
2aad5ca
Compare
2aad5ca to
9951988
Compare
|
Yes, agreed with @jparrill comment, for cli this covers it, for |
jparrill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/lgtm |
modules/destroy-hc-bm-cli.adoc
Outdated
| = Destroying a hosted cluster on bare metal by using the CLI | ||
|
|
||
| You can use the `hcp` command-line interface (CLI) to destroy a hosted cluster on bare metal. | ||
| If you created a hosted cluster by using the command-line interface (CLI), you can destroy that hosted cluster and its back-end resources by deleting the configuration YAML file for the hosted cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lahinson, you're not actually deleting the configuration file though. oc delete removes the resource(s) described in the YAML configuration, which itself holds Kubernetes API objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jab-rh Thanks for the feedback. I revised the line to no longer state the the file is deleted.
9951988 to
9f338aa
Compare
|
New changes are detected. LGTM label has been removed. |
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick enterprise-4.20 |
|
/cherry-pick enterprise-4.19 |
|
/cherry-pick enterprise-4.18 |
|
@jab-rh: new pull request created: #99059 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jab-rh: new pull request created: #99060 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick enterprise-4.17 |
|
@jab-rh: new pull request created: #99061 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jab-rh: new pull request created: #99062 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.17+
Issue: https://issues.redhat.com/browse/OSDOCS-15346
Link to docs preview: https://98745--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-destroy/hcp-destroy-bm.html#destroy-hc-bm-cli_hcp-destroy-bm
QE review:
Additional information: