CNV#62399: 4.20 Descheduler profile doc

[danielclowers]

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/CNV-62399

Link to docs preview:
https://98815--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-enabling-descheduler-evictions.html#virt-enabling-descheduler-evictions_virt-enabling-descheduler-evictions

QE review:

• QE has approved this change.

Additional information:

[ocpdocs-previewbot]

🤖 Wed Oct 15 19:32:14 - Prow CI generated the docs preview:

https://98815--ocpdocs-pr.netlify.app/
https://98815--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-manage/hcp-manage-virt.html
https://98815--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/descheduler/index.html
https://98815--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-enabling-descheduler-evictions.html

[ousleyp]

Good work overall, but I have a couple questions and some nits/suggestions. Let me know if you have questions about my comments.

[danielclowers]

@ousleyp i applied all your suggestions. and just reworded a few things. also swapped steps 2 and 3. can you take a look again?

also, do you think i should leave this or get rid of it

<1> As of {VirtProductName} 4.20, the `KubeVirtRelieveAndMigrate` profile replaces the `DevKubeVirtRelieveAndMigrate` profile.  

[ousleyp]

Thanks for making the changes! I think it's looking good but just a few more comments re: the callouts. Feel free to ping me for merge when you resolve those.

[tiraboschi]

I'd also add another note.
In section https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/virtualization/managing-vms#virt-enabling-descheduler-evictions
we are explaining ho to enable PSI on the worker nodes and in the example snippet we are correctly naming the machine config object as 99-openshift-machineconfig-worker-psi-karg but I'd also add an explicit note mentioning that the name of the machine config object is relevant. This because the machine config objects are processed in lexicographical order and by default a machine config starting with 98-... is disabling PSI so, in order to really enable it, the machine config should be named 99-....

[tiraboschi]

LGTM

[openshift-ci]

@danielclowers: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ousleyp]

Excellent work, lgtm :)

[ousleyp]

/cherrypick enterprise-4.20

[openshift-cherrypick-robot]

@ousleyp: new pull request created: #100681

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.