Skip to content

OSDOCS#14987: Noting Kube APIs removed (again) in OCP 4.20) #98816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

OSDOCS#14987: Noting Kube APIs removed (again) in OCP 4.20) #98816

merged 1 commit into from
Oct 9, 2025

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Sep 10, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2025
@bergerhoffer bergerhoffer added this to the Planned for 4.20 GA milestone Sep 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 10, 2025 •
edited
Loading

🤖 Fri Oct 03 15:15:48 - Prow CI generated the docs preview:

https://98816--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/preparing_for_updates/updating-cluster-prepare.html

bergerhoffer
bergerhoffer commented Sep 10, 2025
View reviewed changes
modules/update-preparing-list.adoc Outdated
|`admissionregistration.k8s.io/v1`
|link:https://kubernetes.io/docs/reference/using-api/deprecation-guide/#webhook-resources-v122[Yes]

// TODO: Check on ValidatingAdmissionPolicy / ValidatingAdmissionPolicyBinding from KCS - those aren't listed in the Kube deprecation guide for 1.22
Copy link
Contributor Author

@bergerhoffer bergerhoffer Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KCS also lists ValidatingAdmissionPolicy or ValidatingAdmissionPolicyBinding.

But the Kubernetes migration docs (and our OCP 4.9 docs) don't list ValidatingAdmissionPolicy or ValidatingAdmissionPolicyBinding for admissionregistration.k8s.io/v1beta. Only MutatingWebhookConfiguration and ValidatingWebhookConfiguration. Just checking whether it's appropriate to add these two or not?

Copy link

@jubittajohn jubittajohn Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openshift/kubernetes/blob/release-4.19/openshift-kube-apiserver/filters/apirequestcount/deprecated.go#L13-L17

bergerhoffer
bergerhoffer commented Sep 10, 2025
View reviewed changes
@bergerhoffer bergerhoffer force-pushed the OSDOCS-14987 branch 2 times, most recently from 71771c4 to 7597d66 Compare September 24, 2025 15:11
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Sep 24, 2025

/retest

1 similar comment
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Sep 24, 2025

/retest

wangke19
wangke19 reviewed Sep 25, 2025
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19
Copy link

wangke19 commented Oct 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Oct 9, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 9, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 9, 2025
xenolinux
xenolinux reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 9, 2025
@bergerhoffer bergerhoffer merged commit 66ce6a6 into openshift:main Oct 9, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Oct 9, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 9, 2025

@bergerhoffer: new pull request created: #100277

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

+2 more reviewers

@jubittajohn jubittajohn jubittajohn left review comments

@wangke19 wangke19 wangke19 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wangke19 wangke19

Labels

branch/enterprise-4.20 lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.20 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@bergerhoffer @ocpdocs-previewbot @wangke19 @openshift-cherrypick-robot @jubittajohn @xenolinux