Skip to content

Conversation

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 7, 2018
@adellape
Copy link
Contributor Author

adellape commented Jun 7, 2018

@ahardin-rh PTAL at this first draft. OK with getting it merged early and continue editing as more comes in (e.g., diagram).

@adellape
Copy link
Contributor Author

adellape commented Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etcd maybe not 100% become a static pod, this depends on how etcd host is defined, if etcd co-locate with master, then etcd would be static pod, if etcd is a standalone host, there is no etcd static pod, just a common etcd rpm install.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the area referenced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not available yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/cert/certificate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/OpenShift/{product-title}

@ahardin-rh
Copy link
Contributor

@adellape Just a few comments from me 👍

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 8, 2018
@adellape adellape merged commit c08662e into openshift:master Jun 14, 2018
@adellape
Copy link
Contributor Author

/cherrypick enterprise-3.10

@openshift-cherrypick-robot

@adellape: new pull request created: #10104

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.10 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants