[RHDEVDOCS-6630] Enhancements of spec.tektonpruner for 1.20 #99108
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
do-not-merge/work-in-progress
ochromy
force-pushed
the
RHDEVDOCS-6630
branch
5 times, most recently
from
22fa7b1 to
69c397f
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
🤖 Wed Sep 24 13:00:58 - Prow CI generated the docs preview: |
ochromy
force-pushed
the
RHDEVDOCS-6630
branch
2 times, most recently
from
8d4acba to
036dcee
Compare
ochromy
force-pushed
the
RHDEVDOCS-6630
branch
from
036dcee to
0e5ffc6
Compare
ochromy
changed the title
|
Hello @ochromy, good job on the PR. Please take a look at the PR and incorporate the feedback. Let me know in case of any doubts. |
ochromy
force-pushed
the
RHDEVDOCS-6630
branch
4 times, most recently
from
843554e to
c49477b
Compare
|
|
||
| [cols="3,1,3,2,4",options="header"] | ||
| |=== | ||
| | Name | Type | Description | Labels | Sample |
There was a problem hiding this comment.
@ochromy You can remove the Sample column and given example. Those are just given for reference
|
|
||
| [cols="3,1,3,4",options="header"] | ||
| |=== | ||
| | Name | Type | Description | Sample |
There was a problem hiding this comment.
@ochromy You can remove the Sample column and given example. Those are just given for reference
|
|
||
| The event-based pruner exposes detailed metrics through the `tekton-pruner-controller` controller `Service` definition on port `9090` in OpenTelemetry format for monitoring, troubleshooting, and capacity planning. | ||
|
|
||
| Following are categories of the metrics exposed: |
There was a problem hiding this comment.
The following categories describe the metrics exposed by the event-based pruner:
|
|
||
| Performance timing metrics:: | ||
|
|
||
| Following are the performance timing metrics exposed by the event-based pruner: |
There was a problem hiding this comment.
The following performance timing metrics are exposed by the event-based pruner:
|
|
||
| Resource processing metrics:: | ||
|
|
||
| Following are the resource processing metrics exposed by the event-based pruner: |
There was a problem hiding this comment.
The following resource processing metrics are exposed by the event-based pruner:
|
|
||
| State tracking metrics:: | ||
|
|
||
| Following are the state tracking metrics exposed by the event-based pruner: |
There was a problem hiding this comment.
The following state tracking metrics are exposed by the event-based pruner:
|
@ochromy, good job on the PR. Left a few comments for you to consider. PTAL. |
ochromy
force-pushed
the
RHDEVDOCS-6630
branch
from
90cfeef to
4c87f14
Compare
|
Thank you for the examples @Dhruv-Soni11 |
|
@ochromy, the lead-in sentence feedback for the Error monitoring metrics section has not been applied yet. PTAL. Also, the newly modified lead-in sentences look incorrectly formatted. Can you please indent it again by adding a + sign and check how it looks? |
tektonconfig config include improvements no1 add observability metrics add label table include obs in assembly remove note from obs add nbsp to promql style improvements no1 remove tp notice add service for the controller include TP snippet dev review no1 dev review no2 qe review no1 prep for peer review peer review no1 peer review no2 peer review no3 peer review no4 peer review no6 mr feedback no1 mr feedback no3
ochromy
force-pushed
the
RHDEVDOCS-6630
branch
from
4c87f14 to
ab747d4
Compare
|
@ochromy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick pipelines-docs-1.20 |
1 similar comment
|
/cherrypick pipelines-docs-1.20 |
|
@Dhruv-Soni11: new pull request created: #99633 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Version(s):
Issue:
Link to docs preview:
QE review: