Skip to content

Conversation

@JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Sep 16, 2025

@openshift-ci-robot
Copy link

@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/OSDOCS-16162

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 16, 2025

@openshift-ci-robot
Copy link

@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/OSDOCS-16162

Link to docs preview:
https://99162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#limitations-for-udn_about-user-defined-networks:~:text=Layer2%20egress%20IP%20limitations%3A

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anuragthehatter
Copy link

/assign @huiran0826 Can you help taking a look? Thanks

@huiran0826
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
Copy link

@martinkennelly martinkennelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

just one nit but up to you

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2025

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/OSDOCS-16162

Link to docs preview:
https://99162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#limitations-for-udn_about-user-defined-networks:~:text=Layer2%20egress%20IP%20limitations%3A

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/OSDOCS-16162

Link to docs preview:
https://99162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#limitations-for-udn_about-user-defined-networks:~:text=Layer2%20egress%20IP%20limitations%3A

QE review:

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s):
4.18+

Issue:
https://issues.redhat.com/browse/OSDOCS-16162

Link to docs preview:
https://99162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#limitations-for-udn_about-user-defined-networks:~:text=Layer2%20egress%20IP%20limitations%3A

QE review:

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 22, 2025
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 23, 2025
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM!

@bergerhoffer bergerhoffer added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 23, 2025
@JoeAldinger JoeAldinger merged commit c8c377b into openshift:main Sep 23, 2025
2 checks passed
@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.19

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #99572

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #99573

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #101247

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bscott-rh
Copy link
Contributor

Resolved the enterprise-4.21 conflict in #101246 without needing to do an additional cherrypick.

@openshift-cherrypick-robot

@JoeAldinger: #99162 failed to apply on top of branch "enterprise-4.21":

Applying: OSDOCS-161612:adds Layer2 EIP limitations for UDN
Using index info to reconstruct a base tree...
M	modules/nw-udn-limitations.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-udn-limitations.adoc
CONFLICT (content): Merge conflict in modules/nw-udn-limitations.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-161612:adds Layer2 EIP limitations for UDN

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 lgtm Indicates that a PR is ready to be merged. ok-to-merge size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants