-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-161612:adds Layer2 EIP limitations for UDN #99162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Mon Sep 22 14:24:33 - Prow CI generated the docs preview: |
|
@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @huiran0826 Can you help taking a look? Thanks |
4b00233 to
33f9ce0
Compare
|
/lgtm |
martinkennelly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
just one nit but up to you
33f9ce0 to
b600cdd
Compare
|
@JoeAldinger: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoeAldinger: No Jira issue with key OSDOCS-161612 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label merge-review-in-progress |
bergerhoffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge review LGTM!
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
@JoeAldinger: new pull request created: #99572 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@JoeAldinger: new pull request created: #99573 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.20 |
|
@bscott-rh: new pull request created: #101247 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Resolved the enterprise-4.21 conflict in #101246 without needing to do an additional cherrypick. |
|
@JoeAldinger: #99162 failed to apply on top of branch "enterprise-4.21": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.18+
Issue:
https://issues.redhat.com/browse/OSDOCS-16162
Link to docs preview:
https://99162--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/primary_networks/about-user-defined-networks.html#limitations-for-udn_about-user-defined-networks:~:text=Layer2%20egress%20IP%20limitations%3A
QE review:
Additional information: