-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#59719: RN for new runbooks in 4.20 #99413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.20
Are you sure you want to change the base?
OSDOCS#59719: RN for new runbooks in 4.20 #99413
Conversation
🤖 Mon Oct 20 13:57:16 - Prow CI generated the docs preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jirka, a couple of things to address. Also please squash your commits before requesting merge review. :) Thanks!
Fixing up markup Capitalization tweaks Fixing indentation Applying peer review Apply suggestions from code review Co-authored-by: Pan Ousley <pousley@redhat.com>
9af8e8d
to
951cf2a
Compare
@jherrman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ousleyp , d'oh, forgot about squashing, apologies! Anyhow, should be reasonably pumpkin-shaped now, and your suggestions worked in as well, so hopefully it's good to go :-) |
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/CNV-59719
Link to docs preview:
https://99413--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html#virt-4-20-monitoring_virt-4-20-release-notes
QE review: