OSDOCS-16244#integrating GCP assemblies #99486
Merged
+21
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/M
brendan-daly-red-hat
force-pushed
the
OSDOCS-16244
branch
from
48786e4 to
8cc98e0
Compare
brendan-daly-red-hat
force-pushed
the
OSDOCS-16244
branch
from
8cc98e0 to
0fad789
Compare
|
@brendan-daly-red-hat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
@jianli-wei, PTAL |
|
/LGTM |
Contributor
Author
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
xenolinux
added
merge-review-in-progress
xenolinux
removed
the
merge-review-in-progress
Contributor
|
/cherrypick enterprise-4.20 |
|
@xenolinux: new pull request created: #100398 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-16244
Link to docs preview:
These are the modules I moved from 'Installing a cluster on GCP with network customizations' to 'Installing a cluster on GCP with customizations':
Revised this text to include references to network customizations:
QE review:
Additional information:
GCP assembly integration (Google Doc outlining the proposed changes)