[OSDOCS-16293]: Clarifying prereq for HCP on OpenShift Virtualization #99568
Conversation
openshift-ci
bot
added
the
size/XS
|
🤖 Tue Oct 07 15:46:16 - Prow CI generated the docs preview: |
|
@LiangquanLi930 When you can, PTAL. Thank you! |
lahinson
changed the title
|
/lgtm |
|
/lgtm |
|
Maybe we can add that when defautl pod network is used for the HCP cluster we support only live migratin for the HCP nodes if the infra CNI is ovn-kubernetes |
lahinson
force-pushed
the
ocpbugs-62115-hcp-virt-prereq
branch
from
02ca21e to
3eb01c7
Compare
|
New changes are detected. LGTM label has been removed. |
lahinson
added
the
merge-review-needed
skopacz1
added
the
merge-review-in-progress
skopacz1
left a comment
skopacz1
left a comment
There was a problem hiding this comment.
One unrelated nit but otherwise LGTM! Feel free to merge this PR yourself, or let me know if you'd like me to merge it for you
modules/hcp-virt-prereqs.adoc
Outdated
| * The {product-title} management cluster has {VirtProductName}, version 4.14 or later, installed on it. For more information, see "Installing OpenShift Virtualization using the web console". | ||
| * The {product-title} management cluster is on-premise bare metal. | ||
| * The {product-title} management cluster is configured with OVNKubernetes as the default pod network CNI. | ||
| * The {product-title} management cluster must be configured with `OVNKubernetes` as the default pod network CNI. Live migration is supported for nodes only if the CNI is OVN-Kubernetes. |
There was a problem hiding this comment.
The only nit is that I don't see "CNI" spelled out anywhere in this prereqs section, maybe that would be worth doing.
There was a problem hiding this comment.
Good point. I'll spell it out.
skopacz1
added
ok-to-merge
and removed
merge-review-in-progress
lahinson
force-pushed
the
ocpbugs-62115-hcp-virt-prereq
branch
from
3eb01c7 to
b8b8f89
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
@lahinson: new pull request created: #100139 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #100140 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #100141 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #100142 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Version(s): 4.17+
Issue: https://issues.redhat.com/browse/OCPBUGS-62115
Link to docs preview: https://99568--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-virt.html#hcp-virt-prereqs_hcp-deploy-virt
QE review:
Additional information: