Skip to content

Conversation

@lahinson
Copy link
Contributor

@lahinson lahinson commented Sep 23, 2025

Version(s): OCP 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-16009

Link to docs preview: https://99578--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-manage/hcp-manage-virt.html#hcp-virt-evict-vms_hcp-manage-virt

QE review:

  • QE has approved this change.

Additional information: This update also needs to be applied to ACM 2.10 and ACM 2.11, which correspond with the OCP 4.15 and 4.16 docs

@lahinson lahinson added this to the Continuous Release milestone Sep 23, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 23, 2025

@lahinson lahinson force-pushed the osdocs-16009-hcp-evictionstrategy branch 4 times, most recently from ecbbbd8 to 9e449e0 Compare October 2, 2025 15:00
@heliubj18
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
Copy link
Contributor

@mgencur mgencur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor issues. Otherwise looks good.

@lahinson lahinson force-pushed the osdocs-16009-hcp-evictionstrategy branch from 9e449e0 to ce2e39f Compare October 6, 2025 15:55
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

New changes are detected. LGTM label has been removed.

@lahinson lahinson force-pushed the osdocs-16009-hcp-evictionstrategy branch from ce2e39f to 8454814 Compare October 6, 2025 17:51
@lahinson lahinson added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 6, 2025
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 6, 2025
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first steps seems pretty unnecessary (and a lot of text)- if there's something from there you want to share, you could explain it in the intro text.

But for the purposes of merge review, LGTM!

@bergerhoffer bergerhoffer added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 6, 2025
@lahinson
Copy link
Contributor Author

lahinson commented Oct 7, 2025

@bergerhoffer Thanks for the review! I see your point about that first step.

@Skalador In the first step of this procedure, is the main purpose of running the following command to learn about the hyperconverged resource and the purpose of setting the evictionStrategy parameter?

$ oc explain hyperconverged.spec.evictionStrategy

If so, would it be okay to change the first step to something like, "To learn more about the hyperconverged resource and the allowed values for the evictionStrategy parameter, enter the following command:"

@Skalador
Copy link
Contributor

Skalador commented Oct 10, 2025

@lahinson Yes it is to learn about the hyperconverged.spec.evictionStrategy options. Your proposal also is fine. Feel free to reduce the bloat of text with

"To learn more about the hyperconverged resource and the allowed values for the evictionStrategy parameter, enter the following command:"

@lahinson lahinson force-pushed the osdocs-16009-hcp-evictionstrategy branch from 8454814 to 371f1c4 Compare October 10, 2025 16:01
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

@lahinson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lahinson lahinson merged commit 6366064 into openshift:main Oct 10, 2025
2 checks passed
@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.17

@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.18

@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.19

@lahinson
Copy link
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@lahinson: #99578 failed to apply on top of branch "enterprise-4.17":

Applying: Adding evictionStrategy docs
.git/rebase-apply/patch:34: trailing whitespace.
In cases where KubeVirt virtual machines (VMs) cannot be live migrated, such as when you use GPU passthrough, the VMs must be evicted at the same time as the `NodePool` resource of the hosted cluster. Otherwise, the compute nodes might be shut down without being drained from the workload. This might also happen when you are upgrading the {VirtProductName} Operator. To achieve a synchronized restart, you can set the `evictionStrategy` parameter on the `hyperconverged` resource to ensure that only VMs that are drained from workloads are rebooted. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	hosted_control_planes/hcp-manage/hcp-manage-virt.adoc
Falling back to patching base and 3-way merge...
Auto-merging hosted_control_planes/hcp-manage/hcp-manage-virt.adoc
CONFLICT (content): Merge conflict in hosted_control_planes/hcp-manage/hcp-manage-virt.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Adding evictionStrategy docs

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lahinson: new pull request created: #100347

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lahinson: new pull request created: #100348

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lahinson: new pull request created: #100349

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants