-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-16009]: Adding evictionStrategy docs #99578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDOCS-16009]: Adding evictionStrategy docs #99578
Conversation
|
🤖 Fri Oct 10 16:12:44 - Prow CI generated the docs preview: |
ecbbbd8 to
9e449e0
Compare
|
/lgtm |
mgencur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor issues. Otherwise looks good.
9e449e0 to
ce2e39f
Compare
|
New changes are detected. LGTM label has been removed. |
ce2e39f to
8454814
Compare
|
/label merge-review-in-progress |
bergerhoffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first steps seems pretty unnecessary (and a lot of text)- if there's something from there you want to share, you could explain it in the intro text.
But for the purposes of merge review, LGTM!
|
@bergerhoffer Thanks for the review! I see your point about that first step. @Skalador In the first step of this procedure, is the main purpose of running the following command to learn about the
If so, would it be okay to change the first step to something like, "To learn more about the |
|
@lahinson Yes it is to learn about the
|
8454814 to
371f1c4
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
@lahinson: #99578 failed to apply on top of branch "enterprise-4.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #100347 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #100348 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #100349 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): OCP 4.17+
Issue: https://issues.redhat.com/browse/OSDOCS-16009
Link to docs preview: https://99578--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-manage/hcp-manage-virt.html#hcp-virt-evict-vms_hcp-manage-virt
QE review:
Additional information: This update also needs to be applied to ACM 2.10 and ACM 2.11, which correspond with the OCP 4.15 and 4.16 docs