-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-15182: Installing New ROSA & OSD Cluster with OCP 4.20 #99648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3a34057 to
b38a854
Compare
|
@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion
| ifdef::openshift-rosa-hcp[] | ||
| * **New version of {product-title} available.** {product-title} version 4.20 is now available for new clusters. | ||
| // re-add once upgrade to 4.20 is available | ||
| // For more information about upgrading to this latest version, see xref:../upgrading/rosa-hcp-upgrading.adoc#rosa-hcp-upgrading[Upgrading {hcp-title} clusters]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of simplification, you could likely revise this to:
| // For more information about upgrading to this latest version, see xref:../upgrading/rosa-hcp-upgrading.adoc#rosa-hcp-upgrading[Upgrading {hcp-title} clusters]. | |
| * **New version of {product-title} available.** {product-title} version 4.20 is now available for new clusters. | |
| // re-add once upgrade to 4.20 is available | |
| // For more information about upgrading to this latest version, see | |
| ifdef::openshift-rosa[] | |
| xref:../upgrading/rosa-upgrading-sts.adoc#rosa-upgrading-sts[Upgrading ROSA (classic architecture) clusters]. | |
| endif::openshift-rosa[] | |
| ifdef::openshift-rosa-hcp[] | |
| see xref:../upgrading/rosa-hcp-upgrading.adoc#rosa-hcp-upgrading[Upgrading {hcp-title} clusters]. | |
| endif::openshift-rosa-hcp[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done thanks but also had to modularize release notes with assembly and this quarter new module that Janelle has introduced. rebased and pushed again
|
@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
b38a854 to
e36a4fd
Compare
e36a4fd to
652773d
Compare
osd release notes update osd release notes new module
d21738d to
66dc486
Compare
|
@fmcdonal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/cherrypick enterprise-4.20 |
|
@EricPonvelle: new pull request created: #100830 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@EricPonvelle: new pull request created: #100831 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OSDOCS-15182
Link to docs preview:
Life Cycle Dates
OSD Whats New
ROSA Whats New
Classic Whats New
QE review:
QE approval is NOT required as no procedural change.