Skip to content

Conversation

@fmcdonal
Copy link
Contributor

@fmcdonal fmcdonal commented Sep 24, 2025

Version(s):
4.20

Issue:
https://issues.redhat.com/browse/OSDOCS-15182

Link to docs preview:
Life Cycle Dates
OSD Whats New
ROSA Whats New
Classic Whats New

QE review:
QE approval is NOT required as no procedural change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2025

@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-15182

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2025

@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-15182

Link to docs preview:
Life Cycle Dates
OSD Whats New
ROSA Whats New
Classic Whats New

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2025

@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/OSDOCS-15182

Link to docs preview:
Life Cycle Dates
OSD Whats New
ROSA Whats New
Classic Whats New

QE review:
QE approval is NOT required as no procedural change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

ifdef::openshift-rosa-hcp[]
* **New version of {product-title} available.** {product-title} version 4.20 is now available for new clusters.
// re-add once upgrade to 4.20 is available
// For more information about upgrading to this latest version, see xref:../upgrading/rosa-hcp-upgrading.adoc#rosa-hcp-upgrading[Upgrading {hcp-title} clusters].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of simplification, you could likely revise this to:

Suggested change
// For more information about upgrading to this latest version, see xref:../upgrading/rosa-hcp-upgrading.adoc#rosa-hcp-upgrading[Upgrading {hcp-title} clusters].
* **New version of {product-title} available.** {product-title} version 4.20 is now available for new clusters.
// re-add once upgrade to 4.20 is available
// For more information about upgrading to this latest version, see
ifdef::openshift-rosa[]
xref:../upgrading/rosa-upgrading-sts.adoc#rosa-upgrading-sts[Upgrading ROSA (classic architecture) clusters].
endif::openshift-rosa[]
ifdef::openshift-rosa-hcp[]
see xref:../upgrading/rosa-hcp-upgrading.adoc#rosa-hcp-upgrading[Upgrading {hcp-title} clusters].
endif::openshift-rosa-hcp[]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done thanks but also had to modularize release notes with assembly and this quarter new module that Janelle has introduced. rebased and pushed again

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@fmcdonal: This pull request references OSDOCS-15182 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.20

Issue:
https://issues.redhat.com/browse/OSDOCS-15182

Link to docs preview:
Life Cycle Dates
OSD Whats New
ROSA Whats New
Classic Whats New

QE review:
QE approval is NOT required as no procedural change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Oct 20, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
osd release notes update

osd release notes new module
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2025

@fmcdonal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@EricPonvelle EricPonvelle merged commit 902c686 into openshift:main Oct 21, 2025
2 checks passed
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #100830

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #100831

In response to this:

/cherrypick enterprise-4.20
/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants