Skip to content

Conversation

jseseCCS
Copy link
Contributor

@jseseCCS jseseCCS commented Sep 24, 2025

Version(s): Fix version 4.20

Issue: OSDOCS-13110

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: I made changes to this topic: 7.1.4 PatternFly guidelines

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2025

@jseseCCS: This pull request references OSDOCS-13110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

Version(s): Fix version 4.20

Issue: OSDOCS-13110

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: I made changes to this topic: 7.1.4 PatternFly guidelines
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2025

@jseseCCS: This pull request references OSDOCS-13110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

Version(s): Fix version 4.20

Issue: OSDOCS-13110

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: I made changes to this topic: 7.1.4 PatternFly guidelines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Sep 24, 2025

@jseseCCS: The label(s) /label peer-review-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, ok-to-test, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
Copy link

openshift-ci bot commented Sep 24, 2025

Hi @jseseCCS. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig
Copy link
Member

jhadvig commented Sep 24, 2025

/lgtm

@jhadvig
Copy link
Member

jhadvig commented Sep 24, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
@jseseCCS
Copy link
Contributor Author

/merge-review-needed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@jseseCCS
Copy link
Contributor Author

@jhadvig what do i need to do to merge this?

@opayne1 opayne1 added merge-review-needed Signifies that the merge review team needs to review this PR branch/enterprise-4.20 labels Oct 2, 2025
@opayne1 opayne1 added this to the Planned for 4.20 GA milestone Oct 2, 2025
@opayne1 opayne1 removed the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 2, 2025
@jseseCCS
Copy link
Contributor Author

jseseCCS commented Oct 6, 2025

@yapei hello! are you the right engineer to ask for a QE review on this PR?

@jhadvig
Copy link
Member

jhadvig commented Oct 13, 2025

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@yapei
Copy link

yapei commented Oct 14, 2025

Thanks!!
LGTM

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
…docs

Update PatternFly version ranges per SME feedback (PF5=4.15–4.18, PF6=4.19+)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
Copy link

openshift-ci bot commented Oct 14, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2025

@jseseCCS: This pull request references OSDOCS-13110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

Version(s): Fix version 4.20

Issue: OSDOCS-13110

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: I made changes to this topic: 7.1.4 PatternFly guidelines

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 14, 2025

@jseseCCS: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jseseCCS
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 14, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 14, 2025
@dfitzmau dfitzmau merged commit a0f4087 into openshift:main Oct 14, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #100466

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants