Skip to content

OCPBUGS-32058 Azure Private DNS zone command addition #99698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

OCPBUGS-32058 Azure Private DNS zone command addition #99698

merged 1 commit into from
Oct 2, 2025

Conversation

@jmanthei
Copy link
Contributor

@jmanthei jmanthei commented Sep 25, 2025 •
edited by dfitzmau
Loading

Version(s): All supported versions

Issue: https://issues.redhat.com/browse/OCPBUGS-32058

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 25, 2025 •
edited
Loading

🤖 Wed Oct 01 17:20:37 - Prow CI generated the docs preview:

https://99698--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/networking_operators/external_dns_operator/nw-creating-dns-records-on-azure.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2025
@jmanthei jmanthei force-pushed the OCPBUGS-32058 branch 3 times, most recently from 1f3f3e6 to 1e324ef Compare September 25, 2025 17:46
alebedev87
alebedev87 reviewed Sep 25, 2025
View reviewed changes
@jmanthei jmanthei force-pushed the OCPBUGS-32058 branch 4 times, most recently from cb208b6 to d742293 Compare September 26, 2025 03:07
@jmanthei
Copy link
Contributor Author

jmanthei commented Sep 26, 2025 •
edited
Loading

@melvinjoseph86 small change, PTAL

@melvinjoseph86
Copy link

melvinjoseph86 commented Sep 26, 2025

/label cherry-pick-approved

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2025

@melvinjoseph86: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight openshift-sustaining-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@melvinjoseph86
Copy link

melvinjoseph86 commented Sep 26, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 26, 2025
@jmanthei
Copy link
Contributor Author

jmanthei commented Sep 26, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 26, 2025
@alebedev87
Copy link
Contributor

alebedev87 commented Sep 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 29, 2025
dfitzmau
dfitzmau reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @jmanthei . I added some feedback. Would you be OK to fix these?

@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 29, 2025

Just to check if "all supported" means feature support on certain OCP version or all actively supported OCP versions?

@jmanthei
Copy link
Contributor Author

jmanthei commented Sep 30, 2025

@dfitzmau 4.16+ I believe is the current docset we are maintaining

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@jmanthei jmanthei force-pushed the OCPBUGS-32058 branch 2 times, most recently from ad6f98e to 287040b Compare September 30, 2025 15:06
@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2025

@jmanthei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 1, 2025

LGTM. Please merge!

@dfitzmau dfitzmau merged commit 04fdd91 into openshift:main Oct 2, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 2, 2025

@dfitzmau: new pull request created: #99936

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2025
Merged
@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 2, 2025

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 2, 2025

@dfitzmau: new pull request created: #99938

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 2, 2025

@dfitzmau: new pull request created: #99939

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 2, 2025

@dfitzmau: new pull request created: #99940

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 2, 2025

@dfitzmau: new pull request created: #99941

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfitzmau dfitzmau dfitzmau left review comments

+1 more reviewer

@alebedev87 alebedev87 alebedev87 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alebedev87 alebedev87

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 merge-review-in-progress Signifies that the merge review team is reviewing this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmanthei @ocpdocs-previewbot @melvinjoseph86 @alebedev87 @dfitzmau @openshift-cherrypick-robot