Skip to content

Conversation

@vashirova
Copy link
Member Author

/label OADP

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2025
Copy link
Contributor

@anarnold97 anarnold97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff check and comparisons show content identical

@vashirova
Copy link
Member Author

Diff check and comparisons show content identical

@anarnold97 I'm not sure what I should be looking at, could you elaborate? The only reason there are previews is because I removed include statements for the modules that I'm deleting and they were already commented out. Do you see anything missing? I'll gladly review again. Thanks

@anarnold97
Copy link
Contributor

anarnold97 commented Sep 30, 2025

Diff check and comparisons show content identical

@anarnold97 I'm not sure what I should be looking at, could you elaborate? The only reason there are previews is because I removed include statements for the modules that I'm deleting and they were already commented out. Do you see anything missing? I'll gladly review again. Thanks

@vashirova - you DING-DONG! i diff checked the contents of the pages at docs.redhat with your preview and everything matches

So you did a perfect job... and i checked! 🤣

@vashirova
Copy link
Member Author

Thank you @anarnold97 !

@vashirova vashirova force-pushed the oadp-unused-files-4.14 branch from fe1b54e to 291fb87 Compare October 1, 2025 14:12
@openshift-ci
Copy link

openshift-ci bot commented Oct 1, 2025

@vashirova: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07 shdeshpa07 added this to the Continuous Release milestone Oct 13, 2025
@shdeshpa07 shdeshpa07 merged commit 5c3d1b5 into openshift:enterprise-4.14 Oct 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 OADP Label for all OADP PRs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants