-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OADP unused files 4.14 #99763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP unused files 4.14 #99763
Conversation
|
/label OADP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff check and comparisons show content identical
@anarnold97 I'm not sure what I should be looking at, could you elaborate? The only reason there are previews is because I removed include statements for the modules that I'm deleting and they were already commented out. Do you see anything missing? I'll gladly review again. Thanks |
@vashirova - you DING-DONG! i diff checked the contents of the pages at docs.redhat with your preview and everything matches So you did a perfect job... and i checked! 🤣 |
|
Thank you @anarnold97 ! |
fe1b54e to
291fb87
Compare
|
@vashirova: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description of change:
Removing unused modules in preparation for DITA, see Copy of unused-modules-4.12-main.
Version(s):
OCP 4.14
Issue:
OADP-6773
Link to docs preview:
Only because I removed commented out includes for deleted modules.
QE review:
Bypassing as there are no content changes.