Skip to content

OSDOCS-16201-RE: Documented migrating a br-ex interface to NMState #99769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

OSDOCS-16201-RE: Documented migrating a br-ex interface to NMState #99769

merged 1 commit into from
Oct 7, 2025
+135 −2

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Sep 26, 2025 •
edited
Loading

Version(s):
4.20+

Issue:
OSDOCS-16201

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 26, 2025 •
edited
Loading

🤖 Tue Oct 07 19:13:10 - Prow CI generated the docs preview:

https://99769--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/bare-metal-postinstallation-configuration.html
https://99769--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-installation-workflow.html
https://99769--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-bare-metal.html
https://99769--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-bare-metal-network-customizations.html
https://99769--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/upi/installing-restricted-networks-bare-metal.html

cybertron
cybertron reviewed Sep 26, 2025
View reviewed changes
@dfitzmau dfitzmau force-pushed the OSDOCS-16201-RE branch 3 times, most recently from 3baf0b1 to a587013 Compare September 29, 2025 08:27
cybertron
cybertron reviewed Sep 29, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 30, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2025
cybertron
cybertron reviewed Oct 3, 2025
View reviewed changes
@dfitzmau dfitzmau force-pushed the OSDOCS-16201-RE branch 3 times, most recently from a2d3c4a to b5c557c Compare October 3, 2025 15:35
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2025
cybertron
cybertron reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
mffiedler
mffiedler approved these changes Oct 7, 2025
View reviewed changes
Copy link

@mffiedler mffiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dfitzmau dfitzmau added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 7, 2025
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 7, 2025
stevsmit
stevsmit reviewed Oct 7, 2025
View reviewed changes
modules/migrating-br-ex-bridge-nmstate.adoc Outdated
--
where:

`<nmstate_configuration>`:: Replace `<nmstate_configuration>` with the name of your NMState resource YAML file.
Copy link
Member

@stevsmit stevsmit Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the rendering here to make sure its what you want?

Also it might be as follows according to our doc guidelines (Not sure if this rule has changed as weve kearned more about callouts):

Suggested change
`<nmstate_configuration>`:: Replace `<nmstate_configuration>` with the name of your NMState resource YAML file.
`<nmstate_configuration>`:: Specifies the name of your NMState resource YAML file.

https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#callouts-in-code-blocks

stevsmit
stevsmit reviewed Oct 7, 2025
View reviewed changes
@stevsmit stevsmit added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Oct 7, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

New changes are detected. LGTM label has been removed.

@stevsmit stevsmit added this to the Planned for 4.20 GA milestone Oct 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 2d7afa4 into openshift:main Oct 7, 2025
2 checks passed
@stevsmit
Copy link
Member

stevsmit commented Oct 7, 2025

/cherry-pick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 7, 2025

@stevsmit: new pull request created: #100156

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevsmit stevsmit stevsmit left review comments

+2 more reviewers

@cybertron cybertron cybertron left review comments

@mffiedler mffiedler mffiedler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cybertron cybertron

@mffiedler mffiedler

Labels

branch/enterprise-4.20 ok-to-merge size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.20 GA

Development

Successfully merging this pull request may close these issues.

6 participants

@dfitzmau @ocpdocs-previewbot @stevsmit @openshift-cherrypick-robot @cybertron @mffiedler