Skip to content

Conversation

@mletalie
Copy link
Contributor

@mletalie mletalie commented Sep 29, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 29, 2025

🤖 Wed Oct 08 15:24:01 - Prow CI generated the docs preview:
https://99809--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@mletalie mletalie changed the title Osdocs 12036 [OSDOCS-12036]ROSA-HCP - Image registry mirror config to customers Sep 29, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2025
@mletalie mletalie force-pushed the OSDOCS-12036 branch 4 times, most recently from c69063b to ef2f1a8 Compare October 1, 2025 17:09
$ rosa delete machinepool --cluster=mycluster mp-1
----
ifdef::openshift-rosa-hcp[]
[id="rosa-delete-mirro-set_{context}"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this might be a typo:
rosa-delete-mirro-set -> rosa-delete-mirror-set

@davidleerh
Copy link

on the module docs, can we emphasize at the top that image mirrors only pertain to image reference by digest only at this time (ImageDigestMirrorSets)? and image reference by tag is not available yet with this feature.

I think this is what Aaren (PM) wanted to show to customers.

@mletalie mletalie closed this Oct 2, 2025
@mletalie mletalie reopened this Oct 2, 2025
@mletalie mletalie closed this Oct 2, 2025
@mletalie mletalie reopened this Oct 2, 2025
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2025
@@ -0,0 +1,166 @@
// Module included in the following assemblies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2025
@mletalie mletalie force-pushed the OSDOCS-12036 branch 2 times, most recently from fa48c32 to 491153a Compare October 3, 2025 16:03
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2025
@@ -0,0 +1,100 @@
// Module included in the following assemblies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.

[id="create-image-mirroring_{context}"]
== Create image mirroring

.Procedure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDocDITA.AdmonitionTitle: Admonition titles are not supported in DITA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what issue the bot is flagging here. Will investigate further.

Copy link
Contributor

@AedinC AedinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mletalie. Great work. Just had some very minor style quibbles.

// Module included in the following assemblies:
//
// * openshift_images/image-configuration-hcp.adoc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:_mod-docs-content-type: CONCEPT


IDMS defines a set of cluster-wide policies for registry mirroring. It intercepts image pull requests that identify an image by its unique content-addressable digest. Based on these policies, the IDMS transparently redirects the pull operation from its specified source registry to one or more designated mirror registries.

The benefits of configuring your {product-title} to pull images from a mirrored registry using IDMS include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The benefits of configuring your {product-title} to pull images from a mirrored registry using IDMS include:
The benefits of configuring your {product-title} cluster (?) to pull images from a mirrored registry using IDMS include:


[IMPORTANT]
====
The image mirror configuration feature operates exclusively with image references by digest, meaning that image mirroring will only activate when an image is pulled using its unique and immutable ID. Any image references using a mutable tag are currently not supported by this functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if you should move this note back up to about line 10 when digest is first mentioned- might be more useful for the reader.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call...forgot to move after adding those bullet points. thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note is still here - just in case you forgot to move it, or maybe you've changed your mind and want to keep it here?



.Prerequisites

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some extra pluses here and above.

.Prerequisites


** You have installed and configured the latest ROSA CLI on your installation host.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** You have installed and configured the latest ROSA CLI on your installation host.
** You have installed and configured the latest {rosa-cli-first} on your installation host.


.Procedure

. Add the following `rhcs_image_mirror` resource block to your Terraform configuration file (e.g., `main.tf`), replacing the variable values with your specific requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Add the following `rhcs_image_mirror` resource block to your Terraform configuration file (e.g., `main.tf`), replacing the variable values with your specific requirements.
. Add the following `rhcs_image_mirror` resource block to your Terraform configuration file (for example, `main.tf`), replacing the variable values with your specific requirements.

$ terraform plan
----
+

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra plus


. Once you have confirmed that only one resource (`rhcs_image_mirror`) will be added to your {product-title} cluster, and nothing will be changed or destroyed, run the following command to apply the changes:

+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few extra pluses here and below.


. Click **Enter** to approve the changes.

The `ImageContentSourcePolicy` is now configured on your cluster, and the image mirror will be active. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will it be active- do we know?

=== Q4 2025
ifdef::openshift-rosa-hcp[]
* ** ImageDigestMirrorSets (IDMS) now supported.**
{product-title} now supports ImageDigestMirrorSets (IDMS), enabling clusters to redirect image pulls to a private, mirrored registry. This enhancement is critical for customers in air-gapped or restricted networks, allowing them to host their own mirrors for third-party images while satisfying strict security and compliance requirements. For more information, see xref:../openshift_images/image-configuration-hcp.adoc#images-registry-mirroring_image-configuration-hcp[Image registry mirroring for {product-title}].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a stab at rewriting this to be less passive.

Suggested change
{product-title} now supports ImageDigestMirrorSets (IDMS), enabling clusters to redirect image pulls to a private, mirrored registry. This enhancement is critical for customers in air-gapped or restricted networks, allowing them to host their own mirrors for third-party images while satisfying strict security and compliance requirements. For more information, see xref:../openshift_images/image-configuration-hcp.adoc#images-registry-mirroring_image-configuration-hcp[Image registry mirroring for {product-title}].
{product-title} now supports ImageDigestMirrorSets (IDMS), enabling clusters to redirect image pulls to a private, mirrored registry. This critical enhancement means customers in air-gapped or restricted networks can host their own mirrors for third-party images while satisfying strict security and compliance requirements. For more information, see xref:../openshift_images/image-configuration-hcp.adoc#images-registry-mirroring_image-configuration-hcp[Image registry mirroring for {product-title}].

@mletalie mletalie force-pushed the OSDOCS-12036 branch 5 times, most recently from 63f8b72 to f3dfd8f Compare October 7, 2025 17:34

[IMPORTANT]
====
The image mirror configuration feature operates exclusively with image references by digest, meaning that image mirroring will only activate when an image is pulled using its unique and immutable ID. Any image references using a mutable tag are currently not supported by this functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note is still here - just in case you forgot to move it, or maybe you've changed your mind and want to keep it here?

|===

.Examples
Creating an image mirror configuration for a cluster named `mycluster`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creating an image mirror configuration for a cluster named `mycluster`.
Creates an image mirror configuration for a cluster named `mycluster`.

An ID is automatically generated and assigned to an image mirror during image mirror configuration creation.
====

Creating an image mirror configuration with a specific type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creating an image mirror configuration with a specific type.
Creates an image mirror configuration with a specific type.

====
When editing an image mirror configuration, the new mirrors list completely replaces the existing mirrors list.
====

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra plus.

--mirrors=new-primary.company.com/team,new-secondary.company.com/team
----


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra plus.

====
The image mirror configuration feature operates exclusively with image references by digest, meaning that image mirroring will only activate when an image is pulled using its unique and immutable ID. Any image references using a mutable tag is currently not supported by this functionality.

{product-title} clusters must be in the **Ready** state in order to create image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{product-title} clusters must be in the **Ready** state in order to create image.
{product-title} clusters must be in the **Ready** state in order to create an image.

@@ -353,4 +352,57 @@ Associate a `KubeletConfig` object with an existing `high-pid-pool` machine pool
----
$ rosa edit machinepool -c mycluster --kubelet-configs=set-high-pids high-pid-pool
----

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra plus.

// Module included in the following assemblies:
//
// * rosa_hcp/terraform/rosa-hcp-creating-a-cluster-quickly-terraform.adoc
// * rosa_install_access_delete_clusters/terraform/rosa-classic-creating-a-cluster-quickly-terraform.adoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed as its for HCP only?

Copy link
Contributor

@AedinC AedinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tiny things.

@openshift-ci
Copy link

openshift-ci bot commented Oct 8, 2025

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mletalie mletalie merged commit babf53a into openshift:main Oct 13, 2025
2 checks passed
@mletalie
Copy link
Contributor Author

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@mletalie: new pull request created: #100406

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mletalie: new pull request created: #100407

In response to this:

/cherrypick enterprise-4.19
/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants