-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TRACING-5677 | RHOSDT 3.8, Google Cloud exporter and AWS IAM/ #99810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TRACING-5677 | RHOSDT 3.8, Google Cloud exporter and AWS IAM/ #99810
Conversation
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
Skipping CI for Draft Pull Request. |
|
/test all |
| * link:https://cloud.google.com/monitoring?hl=en[Google Cloud Monitoring] | ||
| * link:https://cloud.google.com/logging?hl=en[Google Cloud Logging] | ||
| * link:https://cloud.google.com/trace?hl=en[Google Cloud Trace] | ||
| * link:https://cloud.google.com/iam/docs/workload-identity-federation-with-kubernetes#deploy[Google Workflow Identity Federation docs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IshwarKanse are you using these commands to configure WIF?
gcloud iam workload-identity-pools create-cred-config \
projects/PROJECT_NUMBER/locations/global/workloadIdentityPools/POOL_ID/providers/WORKLOAD_PROVIDER_ID \
--service-account=SERVICE_ACCOUNT_EMAIL \
--credential-source-file=/var/run/service-account/token \
--credential-source-type=text \
--output-file=credential-configuration.json
Is it possible to use just the k8s SA to push data to the google cloud? e.g. without using the key.json?
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
/test all |
| region: <aws_region_of_log_stream> # <3> | ||
| endpoint: <protocol><service_endpoint_of_amazon_cloudwatch_logs> # <4> | ||
| log_retention: <supported_value_in_days> # <5> | ||
| role_arn: "<iam_role>" # <6> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IshwarKanse we should update our e2e tests https://github.com/openshift/distributed-tracing-qe/tree/main/tests/e2e-otel to use the role_arn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added googlecloud exporter test which used WIF openshift/distributed-tracing-qe#117 We have aws tests using role ARN as well.
|
@pavolloffay: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pavolloffay, you are welcome to close this Draft PR because I opened #102760. |
Version(s):
RHOSDT 3.8
OCP 4.12 - 4.21 (all supported OCP versions)
Issue:
https://issues.redhat.com/browse/TRACING-5677
Link to docs preview:
QE review:
Additional information:
Upstream docs https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/googlecloudexporter