Skip to content

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Oct 1, 2025

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-16255

Link to docs preview:

N/A - files are removed, so there is nothing to preview

QE review:
N/A - just removing unused module files

Additional information:

Making sure that as many control plane pod members ack this PR before merging as possible:

  • Andrea
  • Courtney
  • Jocelyn
  • Kevin
  • Laura
  • Lisa
  • Michael B
  • Michael P
  • Olivia
  • Servesha
  • Tami

Followed the spreadsheet, except had to back out quite a few files that were actually in use, but missed by the script, likely because they were inside conditionals.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 1, 2025

🤖 Mon Oct 06 13:25:08 - Prow CI generated the docs preview:

https://99910--ocpdocs-pr.netlify.app/

@bergerhoffer bergerhoffer force-pushed the OSDOCS-16255 branch 4 times, most recently from eb085dc to bc9fd7c Compare October 2, 2025 16:01
@lpettyjo
Copy link
Contributor

lpettyjo commented Oct 2, 2025

LGTM

Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one module that is still used by OKD. The rest of the OLM modules LGTM.

@tmalove
Copy link
Contributor

tmalove commented Oct 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@cbippley
Copy link
Contributor

cbippley commented Oct 3, 2025

LGTM!

Copy link
Contributor

@kowen-rh kowen-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor Author

Merging, since pretty much all control plane pod members signed off.

@bergerhoffer bergerhoffer merged commit a219456 into openshift:main Oct 6, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.20

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.19

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #100040

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bergerhoffer: #99910 failed to apply on top of branch "enterprise-4.19":

Applying: OSDOCS#16255: Removing unused modules from main+back
Using index info to reconstruct a base tree...
A	modules/nodes-pods-autoscaling-custom-rn-210.adoc
M	modules/persistent-storage-vsphere-backup.adoc
A	modules/wmco-prerequisites.adoc
Falling back to patching base and 3-way merge...
Removing modules/upgrade-49-acknowledgement.adoc
Removing modules/storage-persistent-storage-efs-storage-class.adoc
Removing modules/storage-persistent-storage-efs-pvc.adoc
Removing modules/storage-persistent-storage-efs-provisioner.adoc
Removing modules/storage-persistent-storage-efs-configmap.adoc
Removing modules/storage-persistent-storage-efs-authorization.adoc
Removing modules/service-ca-certificates.adoc
Removing modules/service-accounts-using-credentials-inside-a-container.adoc
Removing modules/service-accounts-enabling-authentication.adoc
Removing modules/service-accounts-configuration-parameters.adoc
Removing modules/prometheus-operator.adoc
CONFLICT (modify/delete): modules/persistent-storage-vsphere-backup.adoc deleted in OSDOCS#16255: Removing unused modules from main+back and modified in HEAD. Version HEAD of modules/persistent-storage-vsphere-backup.adoc left in tree.
Removing modules/persistent-storage-manila-usage.adoc
Removing modules/persistent-storage-manila-install.adoc
Removing modules/persistent-storage-csi-tp-enable.adoc
Removing modules/persistent-storage-csi-olm-driver-uninstall.adoc
Removing modules/persistent-storage-csi-migration-vsphere.adoc
Removing modules/persistent-storage-csi-migration-overview-support-level.adoc
Removing modules/persistent-storage-csi-migration-enable.adoc
Removing modules/persistent-storage-csi-migration-automatic-ga.adoc
Removing modules/persistent-storage-csi-manila-uninstall-operator.adoc
Removing modules/persistent-storage-csi-manila-install-operator.adoc
Removing modules/persistent-storage-csi-manila-install-driver.adoc
Removing modules/persistent-storage-csi-ebs-operator-install.adoc
Removing modules/persistent-storage-csi-ebs-operator-install-driver.adoc
Removing modules/olmv1-publishing-fbc.adoc
Removing modules/olmv1-creating-fbc.adoc
Removing modules/olm-webhook-considerations.adoc
Removing modules/olm-removing-crd-version.adoc
Removing modules/olm-defining-csv-webhooks.adoc
Removing modules/olm-arch-os-support.adoc
Removing modules/olm-adding-new-crd-version.adoc
Removing modules/nodes-scheduler-node-selectors-configuring.adoc
Removing modules/nodes-scheduler-node-projects-configuring.adoc
Removing modules/nodes-scheduler-node-projects-about.adoc
Removing modules/nodes-scheduler-node-names-configuring.adoc
Removing modules/nodes-pods-secrets-creating-tls.adoc
Removing modules/nodes-nodes-configuring-graceful-shutdown.adoc
Removing modules/nodes-nodes-cluster-timeout-graceful-shutdown.adoc
Removing modules/nodes-cluster-resource-override-deploy.adoc
Removing modules/nodes-cluster-overcommit-buffer-chunk.adoc
Removing modules/multi-cluster-about.adoc
Removing modules/lvms-adding-a-storage-class.adoc
Removing modules/ldap-failover-prereqs.adoc
Removing modules/ldap-failover-overview.adoc
Removing modules/ldap-failover-generate-certs.adoc
Removing modules/ldap-failover-configure-sssd.adoc
Removing modules/ldap-failover-configure-openshift.adoc
Removing modules/ldap-failover-configure-apache.adoc
Removing modules/images-create-metadata-define.adoc
Removing modules/hcp-requirements-platform-version.adoc
Removing modules/enabling-plug-in-browser.adoc
Removing modules/enabling-multi-cluster-console.adoc
Removing modules/dynamic-provisioning-gluster-definition.adoc
Removing modules/dynamic-provisioning-ceph-rbd-definition.adoc
Removing modules/configuring-hpa-based-on-application-metrics.adoc
Removing modules/builds-strategy-s2i-force-pull-example.adoc
Removing modules/builds-strategy-force-pull-procedure.adoc
Removing modules/builds-strategy-docker-force-pull-example.adoc
Removing modules/builds-source-input-subman-config.adoc
Removing modules/builds-image-change-trigger-identification.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS#16255: Removing unused modules from main+back

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@bergerhoffer: #99910 failed to apply on top of branch "enterprise-4.18":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.