-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#16255: Removing unused modules from main+back #99910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Mon Oct 06 13:25:08 - Prow CI generated the docs preview: |
eb085dc to
bc9fd7c
Compare
|
LGTM |
michaelryanpeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one module that is still used by OKD. The rest of the OLM modules LGTM.
bc9fd7c to
e04d01b
Compare
|
/lgtm |
|
LGTM! |
kowen-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
e04d01b to
9fbbebb
Compare
|
New changes are detected. LGTM label has been removed. |
|
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Merging, since pretty much all control plane pod members signed off. |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
@bergerhoffer: new pull request created: #100040 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bergerhoffer: #99910 failed to apply on top of branch "enterprise-4.19": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bergerhoffer: #99910 failed to apply on top of branch "enterprise-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.12+
Issue:
https://issues.redhat.com/browse/OSDOCS-16255
Link to docs preview:
N/A - files are removed, so there is nothing to preview
QE review:
N/A - just removing unused module files
Additional information:
Making sure that as many control plane pod members ack this PR before merging as possible:
Followed the spreadsheet, except had to back out quite a few files that were actually in use, but missed by the script, likely because they were inside conditionals.