OSDOCS-16309: Updated the IPoIB docs by including Bond Over Infiniban… #99992
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dfitzmau: This pull request references OSDOCS-16309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
🤖 Fri Oct 17 10:02:39 - Prow CI generated the docs preview: |
|
@dfitzmau: This pull request references OSDOCS-16309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dfitzmau
force-pushed
the
OSDOCS-16309
branch
2 times, most recently
from
627f704 to
0780bbb
Compare
cybertron
left a comment
cybertron
left a comment
There was a problem hiding this comment.
Overall lgtm, but the footnote style change seems to have only been partially applied. I would think that should be cleaned up.
|
@dfitzmau: This pull request references OSDOCS-16309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| -- | ||
| where: | ||
|
|
||
| `<mode>`:: `datagram` is the default mode for an IPoIB interface, and this mode improves optimizes performance and latency. `connected` mode is a supported mode but consider only using this mode when you need to adjust the maximum transmission unit (MTU) value to improve node connectivity with surrounding network devices. |
There was a problem hiding this comment.
"improves optimizes" are we missing an "and", or just pick one adjective?
There was a problem hiding this comment.
datagramis the default mode for an IPoIB interface, and this mode improves optimizes performance and latency.
"and"? Maybe just a new sentence. It's awkward? We usually describe something and then just say "(default)". Unless we want to explain why it's default.
There was a problem hiding this comment.
Thanks!
Updated to state:
<mode>::datagramis the default mode for an IPoIB interface. This mode provides improved CPU performance and low-latency capabilitities for pod-to-pod communication.
dfitzmau
force-pushed
the
OSDOCS-16309
branch
from
4d5809c to
794f4f2
Compare
|
/lgtm |
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dfitzmau
added
the
merge-review-needed
|
@dfitzmau: This pull request references OSDOCS-16309 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
maxwelldb
added
the
merge-review-in-progress
maxwelldb
removed
merge-review-in-progress
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
@dfitzmau: new pull request created: #100754 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #100755 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #100756 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #100757 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #100758 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
Version(s):
4.16+
Issue:
OSDOCS-16309
Link to docs preview: