Added API to get a single cartridge

[lnader]

No description provided.

[adietish]

Thanks a lot for the PR!
I filed a matching issue in our JIRA at https://issues.jboss.org/browse/OSJC-97
I'll add a simple integration and a unit test and push upstream.

[lnader]

Thanks. That would be great.
Lili

----- Original Message -----
From: "André Dietisheim" notifications@github.com
To: "openshift/openshift-java-client" openshift-java-client@noreply.github.com
Cc: "Lili Nader" lnader@redhat.com
Sent: Tuesday, January 28, 2014 9:19:31 AM
Subject: Re: [openshift-java-client] Added API to get a single cartridge (#109)

Thanks a lot for the PR!
I filed a matching issue in our JIRA at https://issues.jboss.org/browse/OSJC-97
I'll add a simple integration and a unit test and push upstream.

---

Reply to this email directly or view it on GitHub:
#109 (comment)

[adietish]

Is the reasoning behind this change to be able to query deprecated cartridges? If it isn't then I'd suggest to query the cached list of cartridges instead of querying the backend

[openshift-bot]

Java Client Action Required: Pull request cannot be automatically merged

[bparees]

@adietish @lnader what's the status on this being merged? the current jenkins plugin can't easily be built by other people until it is (have to cherry-pick in this PR).

[lnader]

I thought I'd wait out until Clayton changes have been merged and then test it again and see if the issue has been fixed.

----- Original Message -----
From: "Ben Parees" notifications@github.com
To: "openshift/openshift-java-client" openshift-java-client@noreply.github.com
Cc: "Lili Nader" lnader@redhat.com
Sent: Thursday, February 6, 2014 11:17:27 AM
Subject: Re: [openshift-java-client] Added API to get a single cartridge (#109)

@adietish @lnader what's the status on this being merged? the current jenkins plugin can't easily be built by other people until it is (have to cherry-pick in this PR).

---

Reply to this email directly or view it on GitHub:
#109 (comment)

[lnader]

Hi Ben,
It looks like with the new changes clayton pushed last week. The obsolete cartridges are returned in the list of cartridges. So there is no changes required in the openshift-java-client or jenkins plug-in.

Lili

----- Original Message -----
From: "Lili Nader" lnader@redhat.com
To: "openshift/openshift-java-client" reply@reply.github.com
Cc: "openshift/openshift-java-client" openshift-java-client@noreply.github.com
Sent: Thursday, February 6, 2014 11:19:42 AM
Subject: Re: [openshift-java-client] Added API to get a single cartridge (#109)

I thought I'd wait out until Clayton changes have been merged and then test it again and see if the issue has been fixed.

----- Original Message -----
From: "Ben Parees" notifications@github.com
To: "openshift/openshift-java-client" openshift-java-client@noreply.github.com
Cc: "Lili Nader" lnader@redhat.com
Sent: Thursday, February 6, 2014 11:17:27 AM
Subject: Re: [openshift-java-client] Added API to get a single cartridge (#109)

@adietish @lnader what's the status on this being merged? the current jenkins plugin can't easily be built by other people until it is (have to cherry-pick in this PR).

---

Reply to this email directly or view it on GitHub:
#109 (comment)

[adietish]

Hi Lili
Thanks for confirming. I'll thus most likely drop this PR and make sure we have support for variables in the url, if you agree.

[lnader]

Sounds good.
Lili

----- Original Message -----
From: "André Dietisheim" notifications@github.com
To: "openshift/openshift-java-client" openshift-java-client@noreply.github.com
Cc: "Lili Nader" lnader@redhat.com
Sent: Monday, February 10, 2014 12:18:43 PM
Subject: Re: [openshift-java-client] Added API to get a single cartridge (#109)

Hi Lili
Thanks for confirming. I'll thus most likely drop this PR and make sure we have support for variables in the url, if you agree.

---

Reply to this email directly or view it on GitHub:
#109 (comment)

[adietish]

closing this PR since there's no need for this as we agreed upon having all cartridges (also the deprecated ones) in /cartridges/

[adietish]

I'm PR'ing supprt for url variables in #114