Skip to content

close responses, avoid leaking connections (#394) #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2019
Merged

close responses, avoid leaking connections (#394) #395

merged 2 commits into from
Sep 18, 2019

Conversation

@adietish
Copy link
Member

@adietish adietish commented Aug 29, 2019 •
edited
Loading

fixes #394

@adietish adietish requested a review from jeffmaury August 29, 2019 13:51
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 29, 2019
@adietish
Copy link
Member Author

adietish commented Aug 29, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 29, 2019
@adietish
Copy link
Member Author

adietish commented Aug 29, 2019

[test]

@adietish
Copy link
Member Author

adietish commented Aug 29, 2019 •
edited
Loading

@jeffmaury ITs are green for me. Also in Eclipse, there are no messages of leaking connections/non-closed responses for the usecases that I tested.
Please review.

@adietish adietish added this to the devex #171 milestone Aug 29, 2019
@adietish
Copy link
Member Author

adietish commented Aug 29, 2019

/ok-to-test

@adietish adietish removed this from the devex #171 milestone Sep 4, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2019
@adietish adietish force-pushed the issue-394 branch 2 times, most recently from 7e3a9a0 to 5deb90f Compare September 9, 2019 08:09
@adietish
close responses, avoid leaking connections (openshift#394)
43de23d 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
use okHttp 4.11 (was: 3.14.2)
acdf642 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 9, 2019

Evaluated for javaclient test up to acdf642

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 9, 2019

Openshift Restclient Java Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/412/) (Base Commit: 08bf382) (PR Branch Commit: acdf642)

@adietish adietish mentioned this pull request Sep 10, 2019
Merged
@jeffmaury
Copy link
Member

jeffmaury commented Sep 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3832e0a into openshift:master Sep 18, 2019
@adietish adietish deleted the issue-394 branch September 18, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

Assignees

@jeffmaury jeffmaury

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

okHttp is complaining about leaking connections, response was not closed

5 participants

@adietish @openshift-bot @jeffmaury @openshift-ci-robot @openshift-merge-robot