Skip to content

Conversation

@chouseknecht
Copy link
Contributor

  • Create objects by passing body=request_dict, rather than a model object. This seems to allow the API to insert defaults for things the user did not specify. Follows the create deployment example.

  • Adds use of dictdiffer to return a list of differences when comparing two objects. Useful for debugging.

  • Fixes broken idempotents discovered during Ansible module testing. Issue was setting object properties of type list to [] rather than None.

  • During exception handling for CRUD operations, check if the exception body startswith('{') before attempting to convert it to JSON. If the exception is related to an authorization problem , for example, it won't contain JSON.

@chouseknecht chouseknecht force-pushed the master branch 3 times, most recently from 7e0a6f4 to 37a363a Compare March 20, 2017 19:12
@chouseknecht chouseknecht merged commit 90a9536 into openshift:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant