Skip to content

Conversation

@chouseknecht
Copy link
Contributor

  • module_utils/k8s_common.py now supports resource definition and src params
  • Fixes role name in README
  • Object compare seems to be return False, even though the dictionary representations are an exact match, as far as I can tell
  • Clean up lots of small things
  • Added attribute_to_snake() method for converting object property names to snake case. When reading a resource definitions on the module side, we may receive camel case, and need to convert it. This keeps us from having to import string_utils at the module level.

dict_a = obj_a.to_dict()
dict_b = obj_b.to_dict()
diffs = diff(dict_a, dict_b)
if not match and not list(diffs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken this will use up the generator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o. that maybe true. that would not be good.

@chouseknecht chouseknecht force-pushed the master branch 4 times, most recently from 4cdfd40 to bc1500a Compare March 24, 2017 05:35
@detiber detiber merged commit cab2b5b into openshift:master Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants