Skip to content

RPM Spec updates #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianvf merged 1 commit into from
Jan 16, 2019
Merged

RPM Spec updates #242

fabianvf merged 1 commit into from
Jan 16, 2019

Conversation

@jmontleon
Copy link
Contributor

@jmontleon jmontleon commented Dec 4, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2018
@djzager
Copy link
Member

djzager commented Dec 5, 2018

My understanding at least is that Ansible, by default, uses python 2. I guess in Fedora Ansible would be installed using python 3?

johnkim76
johnkim76 reviewed Dec 11, 2018
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2018
@jmontleon
Copy link
Contributor Author

jmontleon commented Dec 14, 2018 •
edited
Loading

@djzager

$ rpm -q --whatprovides /usr/bin/ansible-playbook 
ansible-2.7.4-1.fc29.noarch
$ head -n1 /usr/bin/ansible-playbook
#!/usr/bin/python3 -s

We've been asked when submitting the package to default python3 for Fedora and python2 for EPEL. Python 2 is deprecated in Fedora 29 and goes away in Fedora 30 by the sounds of it.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1654835#c1

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@jmontleon jmontleon requested review from djzager and fabianvf January 16, 2019 14:00
@fabianvf fabianvf merged commit ff53e1f into openshift:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djzager djzager djzager approved these changes

@fabianvf fabianvf Awaiting requested review from fabianvf

+1 more reviewer

@johnkim76 johnkim76 johnkim76 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmontleon @djzager @johnkim76 @fabianvf @openshift-ci-robot