Skip to content

Conversation

@fabianvf
Copy link
Member

This will let apply work with all resources, including ones defined by CustomResourceDefinitions, even when the resource was not created with apply

@fabianvf fabianvf requested a review from willthames May 20, 2019 20:18
@fabianvf
Copy link
Member Author

/cherrypick release-0.9

@openshift-cherrypick-robot

@fabianvf: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2019
@willthames
Copy link
Contributor

Is there something that fails without this - if so would be good to get that added to the apply test suite in the k8s module.

@willthames
Copy link
Contributor

All tests in ansible/ansible#49053 pass with this change (with some minor tweaks to the test suite, but more for default apply than this).

@willthames
Copy link
Contributor

I changed the test suite so that it would fail without this change just to double check too.

@openshift-cherrypick-robot

@fabianvf: new pull request created: #295

In response to this:

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants