Skip to content

FIX for #297 #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianvf merged 1 commit into from
May 29, 2019
Merged

FIX for #297 #299

fabianvf merged 1 commit into from
May 29, 2019

Conversation

@Canta
Copy link
Contributor

@Canta Canta commented May 23, 2019

There was a problem when load_json(self.client.request('GET', path))['resources'] is null, as is later expected to be iterated. Therefore, I added a default empty list as output value for that property call.

@Canta
FIX for openshift#297
6049370 
There was a problem when `load_json(self.client.request('GET', path))['resources']` is null, as is later expected to be iterated. Therefore, I added a default empty list as output value for that property call.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2019
@willthames
Copy link
Contributor

willthames commented May 27, 2019 •
edited
Loading

Based on the discussion in #297 (and thanks for your extra work digging into that), I'm happy with this change.

@fabianvf fabianvf merged commit d5881a9 into openshift:master May 29, 2019
@fabianvf
Copy link
Member

fabianvf commented Jun 4, 2019

/cherrypick release-0.8

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 4, 2019

@fabianvf: #299 failed to apply on top of branch "release-0.8":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	openshift/dynamic/client.py
Falling back to patching base and 3-way merge...
Auto-merging openshift/dynamic/client.py
CONFLICT (content): Merge conflict in openshift/dynamic/client.py
Patch failed at 0001 FIX for #297

In response to this:

/cherrypick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabianvf
Copy link
Member

fabianvf commented Jun 4, 2019

/cherrypick release-0.9

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 4, 2019

@fabianvf: new pull request created: #307

In response to this:

/cherrypick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2019
Merged
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
@Canta @willthames
FIX for openshift#297 (openshift#299)
3dfab98 
There was a problem when `load_json(self.client.request('GET', path))['resources']` is null, as is later expected to be iterated. Therefore, I added a default empty list as output value for that property call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@willthames willthames willthames approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Canta @willthames @fabianvf @openshift-cherrypick-robot @openshift-ci-robot