Ensure that namespace and name parameters are used for apply #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resource definitions that are accompanied separately by names and namespaces should be updated and the name and namespace used Fixes openshift#296
openshift-ci-robot
added
the
size/XS
Contributor
Author
|
tbh there should be tests for this, I'm happy for this to be considered a WIP |
Contributor
Author
|
I do think there should be tests, but the test suite here isn't really fit for that purpose. I'll add tests to ansible/ansible#49053 instead |
Contributor
Author
|
Hmm, it seems that this bug doesn't get hit by ansible because ansible patches the metadata with name and namespace parameters before it gets to the openshift library. I tried some test cases but they all worked without this fix! |
Member
|
Yeah I need to fix up the test infra. I'll go ahead and merge this now though |
willthames
added a commit
to willthames/openshift-restclient-python
that referenced
this pull request
Nov 22, 2019
…ft#300) resource definitions that are accompanied separately by names and namespaces should be updated and the name and namespace used Fixes openshift#296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource definitions that are accompanied separately by names
and namespaces should be updated and the name and namespace used
Fixes #296