Update state parameter. Add force parameter. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
approved these changes
Mar 28, 2017
Member
fabianvf
left a comment
fabianvf
left a comment
There was a problem hiding this comment.
Seems clear to me, I much prefer this to the replaced state. On a cursory glance the failing tests look like openshift just went down, would be surprised if rerunning the https://travis-ci.org/openshift/openshift-restclient-python/jobs/215752174 job didn't fix it.
Contributor
|
@chouseknecht I'll look at rebasing this and updating for the k8s/openshift split tomorrow. |
fabianvf
pushed a commit
to fabianvf/openshift-restclient-python
that referenced
this pull request
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comments form bcoca:
patchandreplacereplacedstateforceoption. Combine with statepresentto cause areplace