Stateful set fixes #37
Conversation
fabianvf
commented
Apr 10, 2017
fabianvf
commented
- Rename get_exception to get_exception_class, to match corresponding change in other helpers
- Remove apiVersion from request body, fixes stateful set api mismatch errors.
detiber
left a comment
detiber
left a comment
There was a problem hiding this comment.
apiVerson is an optional field, and since we are mapping the version of the resource to the version of the API we are calling into three shouldn't be an issue with not specifying it here.
|
I'll add some tests for stateful sets and replicasets tomorrow as well |
Fixes stateful set api mismatch errors.
fabianvf
force-pushed
the
stateful-set-fixes
branch
from
09a5971 to
7fb3e3d
Compare
| version_mismatch = pytest.mark.skipif( | ||
| float(pytest.config.getoption('--openshift-version')) < 1.5, | ||
| reason='This API is not supported in openshift versions < 1.5' | ||
| ) |
There was a problem hiding this comment.
Instead of defining version_mismatch here, it might be better to move this to test/functional/conftest.py and rename it to version_gte_1_5. Then it would be available for other tests as well.
fabianvf
force-pushed
the
stateful-set-fixes
branch
3 times, most recently
from
b1b1fbd to
370f9e4
Compare
fabianvf
force-pushed
the
stateful-set-fixes
branch
from
370f9e4 to
9beb266
Compare
|
@detiber ready for review |
test/functional/conftest.py
Outdated
|
|
||
|
|
||
|
|
||
| def version_mismatch(lowest_version=None, highest_version=None, skip_latest=False): |
There was a problem hiding this comment.
I'm probably missing something, but I'm not seeing if this is used anywhere.
There was a problem hiding this comment.
Whoops, totally thought I'd removed that. Copy paste error, my bad.
* No longer pass API version in request body * add tests for replica and stateful sets * add test for horizontal pod autoscaler * add skip condition on version mismatch
2 participants
