Use upstream implementation as the base, maintain only diffs #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
fabianvf
force-pushed
the
rebase-on-upstream
branch
from
a7cfe1d to
fceace0
Compare
fabianvf
force-pushed
the
rebase-on-upstream
branch
from
fceace0 to
d213b82
Compare
fabianvf
changed the title
fabianvf
force-pushed
the
rebase-on-upstream
branch
from
29b13b7 to
d5c1b71
Compare
fabianvf
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
asmacdo
reviewed
Aug 19, 2021
openshift/dynamic/discovery.py
Outdated
| from kubernetes.dynamic.exceptions import ( | ||
| ResourceNotFoundError, | ||
| ResourceNotUniqueError, | ||
| ApiException, |
Contributor
There was a problem hiding this comment.
Optional Nit: For pep8 these should be in alphabetical order, but not a big deal. If the need to be imported in this order, a comment would be nice.
tox.ini
Outdated
| envlist = | ||
| py{27,35}-{lint} | ||
| py{27,35}-openshift-unit | ||
| py{27,39}-{lint} |
Contributor
There was a problem hiding this comment.
Looks like we dont want 27 here anymore.
Member
Author
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asmacdo, fabianvf, jmrodri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.