Skip to content

fixes(#46) ConfigMaps and Secrets do not have status #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chouseknecht merged 1 commit into from
Jun 5, 2017
Merged

fixes(#46) ConfigMaps and Secrets do not have status #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion openshift/helper/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,12 @@ def get_object(self, name, namespace=None):

def patch_object(self, name, namespace, k8s_obj):
self.logger.debug('Starting patch object')
empty_status = self.properties['status']['class']()

if 'status' in self.properties['status']:
empty_status = self.properties['status']['class']()
else:
empty_status = {}

k8s_obj.status = empty_status
k8s_obj.metadata.resource_version = None
self.__remove_creation_timestamps(k8s_obj)
Expand Down Expand Up @@ -499,6 +504,8 @@ def _wait_for_response(self, name, namespace, action):
if action == 'delete':
if not obj:
break
elif obj and not hasattr(obj, 'status'):
break
elif obj and obj.status and hasattr(obj.status, 'phase'):
if obj.status.phase == 'Active':
break
Expand Down