Base64 encode secret string_data for comparisons #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During creation and patching operations, existing objects are pulled down and compared to what is about to be applied. If no differences exist than no change is necessary. Secrets have a convenience parameter of `string_data` which will take a string and do a base64 conversion replacing any keys in `data`. When the existing object is pulled down `string_data` does not exist yet might be in the object to be patched. This might result in a change that is unnecessary. Instead, before doing the comparison, encode anything in `string_data` to base64 and move it into `data` so that proper comparisons can occur.
Contributor
Author
|
This fixes ansible/ansible-kubernetes-modules#3. |
Member
|
nice, build failure unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During creation and patching operations, existing objects are pulled
down and compared to what is about to be applied. If no differences
exist than no change is necessary.
Secrets have a convenience parameter of
string_datawhich will take astring and do a base64 conversion replacing any keys in
data. When theexisting object is pulled down
string_datadoes not exist yet might bein the object to be patched. This might result in a change that is
unnecessary.
Instead, before doing the comparison, encode anything in
string_datato base64 and move it into
dataso that proper comparisons can occur.