Skip to content

OCPBUGS-76474: Backport Update heartbeat on receiving inspection data to 4.21#372

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
jadhaj:backport-pr370-to-4.21
Feb 10, 2026
Merged

OCPBUGS-76474: Backport Update heartbeat on receiving inspection data to 4.21#372
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
jadhaj:backport-pr370-to-4.21

Conversation

@jadhaj
Copy link

@jadhaj jadhaj commented Feb 10, 2026

No description provided.

@jadhaj
Update heartbeat on receiving inspection data
82c7f52 
If the last heartbeat is not recorded, the node is deemed not "fast-trackable", which will cause the
ISO to be ejected when tearing down inspection. This is already a problem, but then a race is
possible when a heartbeat comes right after ejection, and the subsequent operation will consider
the agent alive and the node fast-trackable. In this case, Ironic will try to interact with an agent that
has the ISO disconnected from underneath it, potentially causing I/O errors in the operating system.

Change-Id: I2949753e365cb94f6a459a6b7ef88962b50e3dd8
Signed-off-by: Jad Haj Yahya <jhajyahy@redhat.com>
@openshift-ci openshift-ci bot requested review from elfosardo and zaneb February 10, 2026 09:45
@elfosardo
Copy link

elfosardo commented Feb 10, 2026

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026
@jadhaj jadhaj force-pushed the backport-pr370-to-4.21 branch from a4cc9fc to 82c7f52 Compare February 10, 2026 10:19
@jadhaj jadhaj changed the title Backport PR 370 to 4.21 OCPBUGS-76474: Backport PR 370 to 4.21 Feb 10, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 10, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@jadhaj: This pull request references Jira Issue OCPBUGS-76474, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-76474 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jadhaj jadhaj changed the title OCPBUGS-76474: Backport PR 370 to 4.21 OCPBUGS-76474: Backport Update heartbeat on receiving inspection data to 4.21 Feb 10, 2026
@jadhaj
Copy link
Author

jadhaj commented Feb 10, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@jadhaj: This pull request references Jira Issue OCPBUGS-76474, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.22.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-76474 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

@jadhaj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jadhaj
Copy link
Author

jadhaj commented Feb 10, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@jadhaj: This pull request references Jira Issue OCPBUGS-76474, which is invalid:

  • expected Jira Issue OCPBUGS-76474 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jadhaj
Copy link
Author

jadhaj commented Feb 10, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 10, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@jadhaj: This pull request references Jira Issue OCPBUGS-76474, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-74487 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-74487 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jadhaj.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@jadhaj: This pull request references Jira Issue OCPBUGS-76474, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-74487 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-74487 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo
Copy link

elfosardo commented Feb 10, 2026

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, jadhaj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2026
@elfosardo
Copy link

elfosardo commented Feb 10, 2026

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2026
@hroyrh
Copy link

hroyrh commented Feb 10, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 5a50b52 into openshift:release-4.21 Feb 10, 2026
4 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@jadhaj: Jira Issue OCPBUGS-76474: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-76474 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@hroyrh hroyrh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jadhaj @elfosardo @openshift-ci-robot @hroyrh