-
Notifications
You must be signed in to change notification settings - Fork 77
UPSTREAM: <carry>: migrate bandrade test cases to OTE #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bandrade The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1 |
|
@bandrade: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e903510-d0e9-11f0-811a-7c7efa004e2c-0 |
tests-extension/.openshift-tests-extension/openshift_payload_olmv0.json
Outdated
Show resolved
Hide resolved
tests-extension/.openshift-tests-extension/openshift_payload_olmv0.json
Outdated
Show resolved
Hide resolved
|
Hi @bandrade , any updates? Thanks! |
Hey @jianzhangbjz it's ready for another review /cc @kuiwang02 |
|
@bandrade: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-operator-framework-olm-release-4.21-periodics-e2e-aws-ovn-extended-f1 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0e009dd0-d629-11f0-811d-e77017aae448-0 |
| o.Expect(firstNode).To(o.Equal(deployedNode)) | ||
| }) | ||
|
|
||
| g.It("PolarionID:24850-[OTP]Allow users to edit the deployment of an active CSV", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade there is no qe-app-registry catalogsource by default for non-tests-private prow job.
so, you can not use it directly.
if you still want to use learn package, you could refer to case 37442. (if you have other case which use learn package, same comment.)
and more, there is no [Skipped:Disconnected] for this case, so it means it support disconnected env. please refer to https://github.com/openshift/operator-framework-olm/blob/main/tests-extension/test/qe/README.md#disconnected-environment-support-for-migrated-qe-cases to add 'olmv0util.ValidateAccessEnvironment(oc)' at the beginning of the case
| } | ||
| }) | ||
|
|
||
| g.It("PolarionID:24057-[OTP]Have terminationMessagePolicy defined as FallbackToLogsOnError", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade the case has NonHyperShiftHOST, but the migrated case miss it. please refer to README to add it.
| } | ||
| }) | ||
|
|
||
| g.It("PolarionID:49130-[OTP][Skipped:Disconnected]Default CatalogSources deployed by marketplace do not have toleration for tainted nodes", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade same comment for NonHyperShiftHOST
| exutil.AssertWaitPollNoErr(err, "The error ServiceAccountNotFound still be reported in status") | ||
| }) | ||
|
|
||
| g.It("PolarionID:21130-[OTP]Fetching non-existent `PackageManifest` should return 404", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade change PackageManifest to PackageManifest
after you change, you could meet error when running make update-metadata. you could refer to #1153 (comment) to resolve it.
Migrate non-deprecated bandrade QE cases from openshift-tests-private into the OLMv0 test extension