OPRUN-4610: Revert lifecycle server changes

[perdasilva]

Since we've decided on a different architecture for providing operator lifecycle metadata, this PR reverts the changes made to pave the way for the old architecture (lifecycle-controller + lifecycle-server).

Summary by CodeRabbit

Release Notes

• Chores
  • Removed the lifecycle-server component and its HTTP API endpoints
  • Removed authentication/authorization middleware for lifecycle requests
  • Updated Docker image build configuration to exclude the removed component
  • Removed associated test coverage

[openshift-ci-robot]

@perdasilva: This pull request explicitly references no jira issue.

Details

In response to this:

Since we've decided on a different architecture for providing operator lifecycle metadata, this PR reverts the changes made to pave the way for the old architecture (lifecycle-controller + lifecycle-server).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR removes the lifecycle-server CLI tool entirely: build rules and test targets are deleted from the Makefile, the CLI entrypoint is removed, direct dependencies used only by that tool are converted to indirect requirements in go.mod, and the binary is removed from the container image.

Changes

Lifecycle Server Component Removal

Layer / File(s)	Summary
Build system cleanup Makefile	Lifecycle-server is removed from the build system: LIFECYCLE_SERVER_CMD variable is deleted, the build/olm target recipe no longer invokes the lifecycle-server build, the $(LIFECYCLE_SERVER_CMD): FORCE build rule is deleted, and the unit/lifecycle-server test target is removed.
CLI entry point removal cmd/lifecycle-server/main.go	The lifecycle-server CLI entrypoint is deleted, removing the Cobra root command initialization and registration logic.
Dependency graph adjustment go.mod	Direct dependencies (library-go, golang.org/x/sync, k8s.io/apiserver, k8s.io/klog/v2) are moved to indirect requirements, reflecting the removal of the lifecycle-server tool that was their primary consumer.
Container image cleanup operator-lifecycle-manager.Dockerfile	The COPY instruction that adds the lifecycle-server binary to the runtime image is removed.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR removes code and doesn't add new Ginkgo tests. Repository uses Go testing.T, not Ginkgo. Check is not applicable to this revert PR.
Test Structure And Quality	✅ Passed	The custom check assesses Ginkgo test code quality. This PR deletes lifecycle-server test files but adds no new/modified test code. The check is not applicable.
Microshift Test Compatibility	✅ Passed	This is a revert PR that removes code (lifecycle-server), not adds new tests. The custom check applies to NEW Ginkgo tests only. No new tests are added, so check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR is a revert that removes lifecycle-server code and tests. No new Ginkgo e2e tests are added. The custom check only applies when new tests are added, so it is not applicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR removes lifecycle-server code, not adding or modifying it. The check applies to new/modified deployment manifests, operator code, or controllers. This revert PR is not applicable.
Ote Binary Stdout Contract	✅ Passed	PR removes lifecycle-server binary and all code entirely. No new process-level code with stdout violations introduced. Build and Docker configurations updated accordingly.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR removes lifecycle-server code and unit tests (not e2e tests). No new Ginkgo e2e tests are being added, so the IPv6 and disconnected network compatibility check is not applicable.
Title check	✅ Passed	The title clearly summarizes the main change: reverting lifecycle server changes. It directly reflects the substantial codebase modifications removing lifecycle-server components.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@perdasilva: This pull request references OPRUN-4610 which is a valid jira issue.

Details

In response to this:

Since we've decided on a different architecture for providing operator lifecycle metadata, this PR reverts the changes made to pave the way for the old architecture (lifecycle-controller + lifecycle-server).

Summary by CodeRabbit

Release Notes

• Chores
• Removed the lifecycle-server component and its HTTP API endpoints
• Removed authentication/authorization middleware for lifecycle requests
• Updated Docker image build configuration to exclude the removed component
• Removed associated test coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[fgiudici]

/lgtm

[perdasilva]

/retest

[tmshort]

/verified by tmshort

It removes the old implementation

[openshift-ci-robot]

@tmshort: This PR has been marked as verified by tmshort.

Details

In response to this:

/verified by tmshort

It removes the old implementation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD f4b8ef2 and 2 for PR HEAD 4d96680 in total

[openshift-ci]

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.