Skip to content

Prevent incompatible operators from being resolved (injection variant)#193

Closed
njhale wants to merge 3 commits intoopenshift:masterfrom
njhale:maxocpver-constraint
Closed

Prevent incompatible operators from being resolved (injection variant)#193
njhale wants to merge 3 commits intoopenshift:masterfrom
njhale:maxocpver-constraint

Conversation

@njhale
Copy link
Copy Markdown
Contributor

@njhale njhale commented Sep 17, 2021 •
edited
Loading

One of two ways to implement downstream-only constraints.

Add a downstream-only catalog operator command that injects a dependency resolution system-constraint prohibiting operators incompatible with a cluster's Y-stream release from being installed.

Implementation Pros:

  • doesn't require carrying downstream-only patches in /staging
  • lets us quickly inject more downstream-only constraints on-demand

Cons:

@njhale
refactor(catalog): factor out main command
1aa402f 
Factor the content of main() into an exported function in a separate
package so that it can be invoked externally.
@njhale
refactor(solver): add system-wide constraint registration
caf6398 
Add an exported function that allows system-wide constraints -- i.e constraints
used by all solvers -- to be injected.
@njhale
feat(catalog): inject max ocp version constraints
40c002a 
Add a downstream-only catalog operator command that injects a
dependency resolution system-constraint prohibiting operators
incompatible with a cluster's Y-stream release from being installed.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 17, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@njhale njhale mentioned this pull request Sep 18, 2021
Closed
@njhale
Copy link
Copy Markdown
Contributor Author

njhale commented Sep 18, 2021

/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2021

@njhale: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 40c002a link true /test verify
ci/prow/unit-olm 40c002a link true /test unit-olm
ci/prow/e2e-aws-console-olm 40c002a link true /test e2e-aws-console-olm
ci/prow/e2e-gcp 40c002a link true /test e2e-gcp
ci/prow/e2e-aws-olm 40c002a link true /test e2e-aws-olm
ci/prow/e2e-upgrade 40c002a link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale
Copy link
Copy Markdown
Contributor Author

njhale commented Sep 23, 2021

the team decided to go with the hardcoded approach

@njhale njhale closed this Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@njhale