[release-4.15] OCPBUGS-31479: Rolebinding SSA cherry-pick #721

dtfranz · 2024-03-27T22:40:49Z

Cherry-pick of 0ccf3d9

Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels.

Signed-off-by: Daniel Franz dfranz@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

openshift-ci-robot · 2024-03-27T22:40:54Z

@dtfranz: This pull request references Jira Issue OCPBUGS-31479, which is invalid:

expected dependent Jira Issue OCPBUGS-31080 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick of 0ccf3d9

Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels.

Signed-off-by: Daniel Franz dfranz@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-03-27T22:40:55Z

/hold
until OCPBUGS-31080 is verified.

openshift-ci · 2024-03-27T22:41:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dtfranz
Once this PR has been reviewed and has the lgtm label, please assign anik120 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels. Signed-off-by: Daniel Franz <dfranz@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

kuiwang02 · 2024-03-28T06:30:11Z

/hold

for pre-testing

kuiwang02 · 2024-03-28T07:43:27Z

pre-testing fails and update the jira ticket.

dtfranz · 2024-03-29T17:27:59Z

/jira refresh

openshift-ci-robot · 2024-03-29T17:28:06Z

@dtfranz: This pull request references Jira Issue OCPBUGS-31479, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-31080 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-31080 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-04-05T22:40:35Z

/close
While this backport does address the issue specifically around RoleBindings it's clear there is more going on and this requires a more involved fix.

openshift-ci · 2024-04-05T22:40:48Z

@dtfranz: Closed this PR.

In response to this:

/close
While this backport does address the issue specifically around RoleBindings it's clear there is more going on and this requires a more involved fix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-04-05T22:40:53Z

@dtfranz: This pull request references Jira Issue OCPBUGS-31479. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Cherry-pick of 0ccf3d9

Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels.

Signed-off-by: Daniel Franz dfranz@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-04-11T21:07:45Z

/reopen
@kuiwang02 please see Jira ticket; we'd like to get this merged while we continue to investigate the root cause.

openshift-ci · 2024-04-11T21:08:15Z

@dtfranz: Reopened this PR.

In response to this:

/reopen
@kuiwang02 please see Jira ticket; we'd like to get this merged while we continue to investigate the root cause.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-04-11T21:08:23Z

@dtfranz: This pull request references Jira Issue OCPBUGS-31479, which is invalid:

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-31080 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-31080 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
bug has dependents
dependent bug OPRUN-3267 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Cherry-pick of 0ccf3d9

Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels.

Signed-off-by: Daniel Franz dfranz@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-11T21:47:17Z

@dtfranz: This pull request references Jira Issue OCPBUGS-31479, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-04-11T21:57:26Z

/jira refresh

openshift-ci-robot · 2024-04-11T21:57:31Z

@dtfranz: An error was encountered updating to the POST state for bug OCPBUGS-31479 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


No response returned: Get "https://issues.redhat.com/rest/api/2/issue/15905861/transitions?expand=transitions.fields": GET https://issues.redhat.com/rest/api/2/issue/15905861/transitions?expand=transitions.fields giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-04-11T22:00:24Z

/jira refresh

openshift-ci-robot · 2024-04-11T22:00:28Z

@dtfranz: An error was encountered searching for dependent bug OCPBUGS-31080 for bug OCPBUGS-31479 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-31080": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-31080 giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dtfranz · 2024-04-11T22:27:00Z

/hold
We do actually need SSA on roles - holding till I get that in.

openshift-ci · 2024-04-12T00:12:05Z

@dtfranz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	`3a4a0ea`	link	true	`/test e2e-gcp-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dtfranz · 2024-04-15T22:26:59Z

Closing as we're downstreaming a more complete fix.
/close

openshift-ci · 2024-04-15T22:27:12Z

@dtfranz: Closed this PR.

In response to this:

Closing as we're downstream a more complete fix.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-04-15T22:27:17Z

@dtfranz: This pull request references Jira Issue OCPBUGS-31479. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Cherry-pick of 0ccf3d9

Switch to SSA for RoleBindings during install (as we do now for Services and ClusterRoleBindings) to avoid issues with race conditions and/or failures to retrieve resources due to missing labels.

Signed-off-by: Daniel Franz dfranz@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 6b2b933f7fb5dd1fd6fe7da967f3f22a27c4253c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 27, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024

openshift-ci bot requested review from dinhxuanvu and joelanford March 27, 2024 22:41

dtfranz force-pushed the rolebinding-ssa-cherry-pick-4-15 branch from 16508b6 to 3a4a0ea Compare March 27, 2024 23:18

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 29, 2024

openshift-ci bot requested a review from kuiwang02 March 29, 2024 17:28

openshift-ci bot closed this Apr 5, 2024

openshift-ci bot reopened this Apr 11, 2024

openshift-ci bot closed this Apr 15, 2024

[release-4.15] OCPBUGS-31479: Rolebinding SSA cherry-pick #721

[release-4.15] OCPBUGS-31479: Rolebinding SSA cherry-pick #721

Uh oh!

Conversation

dtfranz commented Mar 27, 2024

Uh oh!

openshift-ci-robot commented Mar 27, 2024

Uh oh!

dtfranz commented Mar 27, 2024

Uh oh!

openshift-ci bot commented Mar 27, 2024

Uh oh!

kuiwang02 commented Mar 28, 2024

Uh oh!

kuiwang02 commented Mar 28, 2024

Uh oh!

dtfranz commented Mar 29, 2024

Uh oh!

openshift-ci-robot commented Mar 29, 2024

Uh oh!

dtfranz commented Apr 5, 2024

Uh oh!

openshift-ci bot commented Apr 5, 2024

Uh oh!

openshift-ci-robot commented Apr 5, 2024

Uh oh!

dtfranz commented Apr 11, 2024

Uh oh!

openshift-ci bot commented Apr 11, 2024

Uh oh!

openshift-ci-robot commented Apr 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2024

Uh oh!

dtfranz commented Apr 11, 2024

Uh oh!

openshift-ci-robot commented Apr 11, 2024

Uh oh!

dtfranz commented Apr 11, 2024

Uh oh!

openshift-ci-robot commented Apr 11, 2024

Uh oh!

dtfranz commented Apr 11, 2024

Uh oh!

openshift-ci bot commented Apr 12, 2024

Uh oh!

dtfranz commented Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 15, 2024

Uh oh!

openshift-ci-robot commented Apr 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openshift-ci-robot commented Apr 11, 2024 •

edited by openshift-ci bot

Loading

dtfranz commented Apr 15, 2024 •

edited

Loading