Skip to content

[release-4.18] OCPBUGS-48636: Fix concurrent namespace resolution #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[release-4.18] OCPBUGS-48636: Fix concurrent namespace resolution #945

wants to merge 3 commits into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 20, 2025

This is an automated cherry-pick of #936

/assign perdasilva

joelanford and others added 3 commits January 20, 2025 19:28
@joelanford
bug: Switch queue informer to use types.Namespace name; relocate dele…
49a6bf5 
…tion handler (#3483)

* switch queue informer to use types.NamespacedName; relocate deletion handler

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Add error message to object count assertion failure

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

---------

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: edb751b9718ffe29e8462ce17867ec3db3b349ff
fixup ns labeler plugin
01e1fe9 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
address lint issues in namespace labeler plugin
51d7722 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 20, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-48486 has been cloned as Jira Issue OCPBUGS-48636. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-48636: Fix concurrent namespace resolution

In response to this:

This is an automated cherry-pick of #936

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-48486: Fix concurrent namespace resolution [release-4.18] OCPBUGS-48636: Fix concurrent namespace resolution Jan 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 20, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48636, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-48486 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48486 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiazha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #936

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 51d7722 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

perdasilva commented Jan 21, 2025

/close

@openshift-ci openshift-ci bot closed this Jan 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@perdasilva: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48636. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #936

/assign perdasilva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@perdasilva perdasilva Awaiting requested review from perdasilva

Assignees

@perdasilva perdasilva

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @perdasilva @joelanford