Skip to content

(TEST) NO-ISSUE: [Default Catalog Tests]: Upgrade go version and refactory #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

(TEST) NO-ISSUE: [Default Catalog Tests]: Upgrade go version and refactory #391

wants to merge 1 commit into from

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jul 1, 2025 •
edited
Loading

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2025

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bentito and oceanc80 July 1, 2025 20:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 mentioned this pull request Jul 1, 2025
Merged
4 tasks
@camilamacedo86 camilamacedo86 force-pushed the remove-vendor branch 2 times, most recently from d5677d0 to 1f059ea Compare July 1, 2025 20:42
@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: UPSTREAM: <carry>: Remove vendor from tests modules under openshift directory NO-ISSUE: Remove vendor from tests modules under openshift directory Jul 1, 2025
@camilamacedo86 camilamacedo86 force-pushed the remove-vendor branch 5 times, most recently from 5fa3f73 to 7c3def0 Compare July 1, 2025 22:12
@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: Remove vendor from tests modules under openshift directory NO-ISSUE: [Default Catalog Tests]: Upgrade go version and refactory Jul 1, 2025
@camilamacedo86
UPSTREAM: <carry>: [Default Catalog Tests]: Upgrade go version and re…
229aa60 
…factory

chore: upgrade Go and refactor project structure

- Upgrade Go from 1.23 to 1.24
- Fix new staticcheck linter issue (QF1008) related to embedded field access
- Move module previously in `openshift/` to a new standalone directory `openshift-test/`
- Remove vendor directory
- Add bingo to manage tooling for the tests
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jul 1, 2025

/test verify

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: [Default Catalog Tests]: Upgrade go version and refactory (TEST) NO-ISSUE: [Default Catalog Tests]: Upgrade go version and refactory Jul 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 229aa60 link true /test verify
ci/prow/okd-scos-e2e-aws-ovn 229aa60 link false /test okd-scos-e2e-aws-ovn
ci/prow/openshift-e2e-aws-techpreview 229aa60 link false /test openshift-e2e-aws-techpreview
ci/prow/openshift-e2e-aws 229aa60 link true /test openshift-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Jul 3, 2025

Closing it was just to show why we need vendor staff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito Awaiting requested review from bentito

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamacedo86 @openshift-ci-robot