Skip to content

NO-ISSUE: Fix experimental manifest copying #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

NO-ISSUE: Fix experimental manifest copying #407

merged 1 commit into from
Jul 17, 2025

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 17, 2025

The standard manifest was being copied rather than the experimental manifest. This meant that the expected feature-flags are not present. This is failing now that we are doing a check for those feature-flags.

@tmshort
UPSTREAM: <carry>: Fix experimental manifest copying
cde752b 
The standard manifest was being copied rather than the experimental
manifest. This meant that the expected feature-flags are not present.
This is failing now that we are doing a check for those feature-flags.

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

@tmshort: This pull request explicitly references no jira issue.

In response to this:

The standard manifest was being copied rather than the experimental manifest. This meant that the expected feature-flags are not present. This is failing now that we are doing a check for those feature-flags.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from anik120 and ankitathomas July 17, 2025 01:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jul 17, 2025

/hold
This fixes the techpreview build. This must pass (or at least, must not fail due to OLMv1) for this to be considered a fix.
Please unhold when techpreview is happy.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2025
@tmshort tmshort mentioned this pull request Jul 17, 2025
Merged
@dtfranz
Copy link
Contributor

dtfranz commented Jul 17, 2025

/retest-required

@dtfranz
Copy link
Contributor

dtfranz commented Jul 17, 2025

The techpreview job succeeded, so I'm removing the hold
/unhold
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2025
@dtfranz
Copy link
Contributor

dtfranz commented Jul 17, 2025

/test okd-scos-e2e-aws-ovn

@openshift-merge-bot openshift-merge-bot bot merged commit 7f00e53 into openshift:main Jul 17, 2025
10 of 11 checks passed
@tmshort tmshort deleted the fix-exp-manifest-copy branch July 17, 2025 07:42
@openshift-bot
Copy link

openshift-bot commented Jul 18, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.20.0-202507171216.p0.g7f00e53.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Jul 18, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.20.0-202507171216.p0.g7f00e53.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

Assignees

@dtfranz dtfranz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort @openshift-ci-robot @dtfranz @openshift-bot