NO-ISSUE: Add verify bindata #441
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ TOOLS_BIN_DIR := $(CURDIR)/bin | |
|
|
||
| #SECTION Development | ||
| .PHONY: verify #HELP To verify the code | ||
| verify: tidy fmt vet lint verify-metadata | ||
|
|
||
| .PHONY: tidy #HELP Run go mod tidy. | ||
| tidy: | ||
|
|
@@ -84,12 +84,12 @@ pkg/bindata/catalog/catalog.go: $(shell find testdata/catalog -type f) | |
| # It prevents various FIPS compliance policies from being applied to this compilation. | ||
| # Do not set globally. | ||
| .PHONY: build | ||
| build: #HELP Build the extended tests binary | ||
|
Contributor
There was a problem hiding this comment. This might cause a conflict with #438, which we are prioritizing.
Contributor
Author
There was a problem hiding this comment. It is fine we can wait that one get merged |
||
| @mkdir -p $(TOOLS_BIN_DIR) | ||
| GO_COMPLIANCE_POLICY="exempt_all" go build -ldflags "$(LDFLAGS)" -mod=vendor -o $(TOOLS_BIN_DIR)/olmv1-tests-ext ./cmd/... | ||
|
|
||
| .PHONY: update-metadata | ||
| update-metadata: build bindata #HELP Build and run 'update-metadata' to generate test metadata | ||
| $(TOOLS_BIN_DIR)/olmv1-tests-ext update --component openshift:payload:olmv1 | ||
| $(MAKE) clean-metadata | ||
|
|
||
|
|
@@ -142,9 +142,10 @@ clean-metadata: #HELP Remove 'codeLocations' from metadata JSON | |
| @echo "Cleaning metadata (removing codeLocations)..." | ||
| @jq 'map(del(.codeLocations))' $(METADATA) > $(METADATA).tmp && mv $(METADATA).tmp $(METADATA) | ||
|
|
||
| .PHONY: verify-metadata #HELP To verify that the metadata and bindata was properly update | ||
| verify-metadata: update-metadata | ||
| @if ! git diff --exit-code >&/dev/null; then \ | ||
| echo "ERROR: Metadata is out of date. Please run 'make build-update' and commit the result."; \ | ||
| exit 1; \ | ||
| fi | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelanford commented on PR439, that this should have
git diff --exit-codeas part of this recipe.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has
@if ! git diff --exit-code >&/dev/null;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that should not be buried in verify-manifests