Skip to content

Conversation

@ankitathomas
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 11, 2023
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-22616, which is invalid:

  • expected Jira Issue OCPBUGS-22616 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jmprusi and ncdc December 11, 2023 14:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankitathomas
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@ncdc
Copy link
Contributor

ncdc commented Dec 11, 2023

/hold

There are a lot of dependency updates in here. Is it possible to limit to solely operator-registry?

Bumps [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) from 1.32.0 to 1.33.0.
- [Release notes](https://github.com/operator-framework/operator-registry/releases)
- [Commits](operator-framework/operator-registry@v1.32.0...v1.33.0)

---
updated-dependencies:
- dependency-name: github.com/operator-framework/operator-registry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@ankitathomas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/vet b524db6 link true /test vet
ci/prow/unit b524db6 link true /test unit
ci/prow/verify-deps b524db6 link true /test verify-deps
ci/prow/openshift-e2e-aws b524db6 link true /test openshift-e2e-aws
ci/prow/verify-commits b524db6 link true /test verify-commits
ci/prow/images b524db6 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-22616. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ankitathomas
Copy link
Contributor Author

After looking through the library affected by the CVE, we aren't affected since we don't use the affected otelhttp.NewHandler method. This is an indirect dependency through operator-registry's CRD validation, which operator-controller does not use.

@ncdc
Copy link
Contributor

ncdc commented Dec 12, 2023

@ankitathomas nice!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants